Re: [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT

2012-07-10 Thread Mark Brown
On Mon, Jul 09, 2012 at 03:15:27PM -0700, Andrew Morton wrote: > OK, this is the second such patch I've seen and it's time to wonder if > we should get grumpy at tglx. afacit 1c6c6952 broke the following > drivers: > sound/soc/codecs/wm8994.c > drivers/mfd/wm831x-auxadc.c > drivers/mfd/wm8350-co

Re: [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT

2012-07-10 Thread Lars-Peter Clausen
On 07/10/2012 12:15 AM, Andrew Morton wrote: > On Fri, 6 Jul 2012 09:33:54 -0700 > Kevin Hilman wrote: > >> Requesting a threaded interrupt without a primary handler and without >> IRQF_ONESHOT is dangerous, and after commit 1c6c6952 (genirq: Reject >> bogus threaded irq requests), these request

Re: [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT

2012-07-09 Thread Andrew Morton
On Fri, 6 Jul 2012 09:33:54 -0700 Kevin Hilman wrote: > Requesting a threaded interrupt without a primary handler and without > IRQF_ONESHOT is dangerous, and after commit 1c6c6952 (genirq: Reject > bogus threaded irq requests), these requests are rejected. This > causes ->probe() to fail, and

[PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT

2012-07-06 Thread Kevin Hilman
Requesting a threaded interrupt without a primary handler and without IRQF_ONESHOT is dangerous, and after commit 1c6c6952 (genirq: Reject bogus threaded irq requests), these requests are rejected. This causes ->probe() to fail, and the RTC driver not to be availble. To fix, add IRQF_ONESHOT to t