Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-20 Thread Moritz Fischer
Hi David, On Fri, Nov 20, 2020 at 03:40:13PM +0800, Xu Yilun wrote: > On Fri, Nov 20, 2020 at 03:30:35PM +0800, David Gow wrote: > > On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer wrote: > > > > > > Hi David, > > > > > > On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote: > > > > Because d

Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-19 Thread Xu Yilun
On Fri, Nov 20, 2020 at 03:30:35PM +0800, David Gow wrote: > On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer wrote: > > > > Hi David, > > > > On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote: > > > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', > > > 'devm_ioremap_resource', and 'd

Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-19 Thread David Gow
On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer wrote: > > Hi David, > > On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote: > > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', > > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' > > functions, it should depend on HAS_IOM

Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-19 Thread Moritz Fischer
Hi David, On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote: > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' > functions, it should depend on HAS_IOMEM. > > This fixes make allyesconfig under UML (ARCH=um), which doe

Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-19 Thread Xu Yilun
Thanks for the fix, looks good to me. Thanks, Yilun On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote: > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' > functions, it should depend on HAS_IOMEM. > > This fixes make

[PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-19 Thread David Gow
Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM. This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM. Signed-off-by: David Gow --- drivers/fpga/Kconfig | 1