Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-03-01 Thread Jason Gunthorpe
On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > commit 6e61907779ba99af785f5b2397a84077c289888a > Author: Julian Braha > Date: Fri Feb 19 18:20:57 2021 -0500 > > drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO > > When RDMA_RXE is enabled and CRYPTO

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-24 Thread Leon Romanovsky
On Tue, Feb 23, 2021 at 11:05:45PM +0100, Arnd Bergmann wrote: > On Tue, Feb 23, 2021 at 10:54 PM Julian Braha wrote: > > On Tuesday, February 23, 2021 4:26:44 PM EST Arnd Bergmann wrote: > > > On Tue, Feb 23, 2021 at 9:46 PM Julian Braha > > > wrote: > > > > > > > > I have other similar

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-23 Thread Arnd Bergmann
On Tue, Feb 23, 2021 at 10:54 PM Julian Braha wrote: > On Tuesday, February 23, 2021 4:26:44 PM EST Arnd Bergmann wrote: > > On Tue, Feb 23, 2021 at 9:46 PM Julian Braha wrote: > > > > > > I have other similar patches that I intend to submit. What should I do, > > > going forward? Should I use

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-23 Thread Julian Braha
On Tuesday, February 23, 2021 4:26:44 PM EST Arnd Bergmann wrote: > On Tue, Feb 23, 2021 at 9:46 PM Julian Braha wrote: > > > > I have other similar patches that I intend to submit. What should I do, > > going forward? Should I use "depends on CRYPTO" for cases like these? > > Should I resubmit

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-23 Thread Arnd Bergmann
On Tue, Feb 23, 2021 at 9:46 PM Julian Braha wrote: > > I have other similar patches that I intend to submit. What should I do, > going forward? Should I use "depends on CRYPTO" for cases like these? > Should I resubmit this patch with that change? No, we should not mix the two methods, that

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-23 Thread Arnd Bergmann
On Tue, Feb 23, 2021 at 9:36 PM Arnd Bergmann wrote: > > For the specific case of CRC32, it might actually a good idea to change > the code to call into the CRC32 code directly instead of the CRYPTO_CRC32 > abstraction. Would that work for RDMA_RXE? On the more general question of whether a

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-23 Thread Arnd Bergmann
On Mon, Feb 22, 2021 at 5:53 PM Randy Dunlap wrote: > On 2/22/21 8:46 AM, Jason Gunthorpe wrote: > > > There is nearly 1000 places that use a 'select CRYPTO_*' in the > > kernel. > > > > I see only 60 'select CRYPTO' statements. I think most of these are correct, as you typically have a single

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-22 Thread Randy Dunlap
On 2/22/21 8:46 AM, Jason Gunthorpe wrote: > On Mon, Feb 22, 2021 at 08:26:10AM -0800, Randy Dunlap wrote: >> On 2/22/21 7:58 AM, Jason Gunthorpe wrote: >>> On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: > On

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-22 Thread Leon Romanovsky
On Mon, Feb 22, 2021 at 12:46:45PM -0400, Jason Gunthorpe wrote: > On Mon, Feb 22, 2021 at 08:26:10AM -0800, Randy Dunlap wrote: > > On 2/22/21 7:58 AM, Jason Gunthorpe wrote: > > > On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: > > >> On Mon, Feb 22, 2021 at 10:39:20AM +0800,

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-22 Thread Jason Gunthorpe
On Mon, Feb 22, 2021 at 08:26:10AM -0800, Randy Dunlap wrote: > On 2/22/21 7:58 AM, Jason Gunthorpe wrote: > > On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: > >> On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: > >>> On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-22 Thread Randy Dunlap
On 2/22/21 7:58 AM, Jason Gunthorpe wrote: > On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: >> On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: >>> On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky wrote: On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-22 Thread Jason Gunthorpe
On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: > On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: > > On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky wrote: > > > > > > On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > > > > commit

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-22 Thread Leon Romanovsky
On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: > On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky wrote: > > > > On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > > > commit 6e61907779ba99af785f5b2397a84077c289888a > > > Author: Julian Braha > > > Date: Fri Feb 19

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-21 Thread Zhu Yanjun
On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky wrote: > > On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > > commit 6e61907779ba99af785f5b2397a84077c289888a > > Author: Julian Braha > > Date: Fri Feb 19 18:20:57 2021 -0500 > > > > drivers: infiniband: sw: rxe: fix kconfig

Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-20 Thread Leon Romanovsky
On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > commit 6e61907779ba99af785f5b2397a84077c289888a > Author: Julian Braha > Date: Fri Feb 19 18:20:57 2021 -0500 > > drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO > > When RDMA_RXE is enabled and CRYPTO is

[PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

2021-02-19 Thread Julian Braha
commit 6e61907779ba99af785f5b2397a84077c289888a Author: Julian Braha Date: Fri Feb 19 18:20:57 2021 -0500 drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO When RDMA_RXE is enabled and CRYPTO is disabled, Kbuild gives the following warning: WARNING: unmet