Hi,
> Am 07.07.2016 um 10:46 schrieb Jacek Anaszewski :
>
> Hi Nikolaus,
>
> On 07/06/2016 12:02 PM, H. Nikolaus Schaller wrote:
>> Hi,
>> finally, I found the time to update the driver according to the many comments
>> received a while ago.
>>
>> Most of them have been worked in, including the
Hi Nikolaus,
On 07/06/2016 12:02 PM, H. Nikolaus Schaller wrote:
Hi,
finally, I found the time to update the driver according to the many comments
received a while ago.
Most of them have been worked in, including the regmap idea and
brightness_set_blocking().
The driver works on our system, so
Hi,
> Am 21.04.2016 um 17:01 schrieb Rob Herring :
>
> On Mon, Apr 18, 2016 at 08:43:16PM +0200, H. Nikolaus Schaller wrote:
>> This is a driver for the Integrated Silicon Solution Inc. LED driver
>> chips IS31FL3196 and IS31FL3199. They can drive up to 6 or 9
>> LEDs.
>>
>> Each LED is individu
On Mon, Apr 18, 2016 at 08:43:16PM +0200, H. Nikolaus Schaller wrote:
> This is a driver for the Integrated Silicon Solution Inc. LED driver
> chips IS31FL3196 and IS31FL3199. They can drive up to 6 or 9
> LEDs.
>
> Each LED is individually controllable in brightness (through pwm)
> in 256 steps s
Hi Nikolaus,
On 04/19/2016 07:21 PM, H. Nikolaus Schaller wrote:
Hi David,
Am 19.04.2016 um 03:25 schrieb David Rivshin (Allworx)
:
[...]
+struct is31fl319x_chip {
+ struct i2c_client *client;
+ struct work_struct work;
+ boolwork_scheduled;
Hi Nikolaus,
On 04/19/2016 07:21 PM, H. Nikolaus Schaller wrote:
Hi Jacek,
Am 19.04.2016 um 11:14 schrieb Jacek Anaszewski :
Hi Nikolaus,
Thanks for the patch. Please refer to my remarks in the code.
Thanks for the remarks!
You're welcome.
On 04/18/2016 08:43 PM, H. Nikolaus Schaller
Hi Jacek,
>>> +static void is31fl319x_brightness_set(struct led_classdev *led_cdev,
>>> + enum led_brightness brightness)
>>> +{
>>> + struct is31fl319x_led *led = container_of(led_cdev,
>>> + struct is31fl319x_led,
>>> +
Hi David,
> Am 19.04.2016 um 03:25 schrieb David Rivshin (Allworx)
> :
>
> Hi Nikolaus,
>
> I recently submitted a driver for the IS31FL32xx family of devices, so
> this driver caught my eye. I have a few comments below.
>
> On Mon, 18 Apr 2016 20:43:16 +0200
> "H. Nikolaus Schaller" wrote:
Hi Jacek,
> Am 19.04.2016 um 11:14 schrieb Jacek Anaszewski :
>
> Hi Nikolaus,
>
> Thanks for the patch. Please refer to my remarks in the code.
Thanks for the remarks!
>
> On 04/18/2016 08:43 PM, H. Nikolaus Schaller wrote:
>> This is a driver for the Integrated Silicon Solution Inc. LED dri
Hi David,
Thanks for the review.
Nikolaus - please address David's remarks.
Thanks,
Jacek Anaszewski
On 04/19/2016 03:25 AM, David Rivshin (Allworx) wrote:
Hi Nikolaus,
I recently submitted a driver for the IS31FL32xx family of devices, so
this driver caught my eye. I have a few comments belo
Hi Nikolaus,
Thanks for the patch. Please refer to my remarks in the code.
On 04/18/2016 08:43 PM, H. Nikolaus Schaller wrote:
This is a driver for the Integrated Silicon Solution Inc. LED driver
chips IS31FL3196 and IS31FL3199. They can drive up to 6 or 9
LEDs.
Each LED is individually contro
Hi Nikolaus,
I recently submitted a driver for the IS31FL32xx family of devices, so
this driver caught my eye. I have a few comments below.
On Mon, 18 Apr 2016 20:43:16 +0200
"H. Nikolaus Schaller" wrote:
> This is a driver for the Integrated Silicon Solution Inc. LED driver
> chips IS31FL3196
Hi Nikolaus,
[auto build test ERROR on j.anaszewski-leds/for-next]
[also build test ERROR on v4.6-rc4 next-20160418]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/H-Nikolaus-Schaller/drivers-
This is a driver for the Integrated Silicon Solution Inc. LED driver
chips IS31FL3196 and IS31FL3199. They can drive up to 6 or 9
LEDs.
Each LED is individually controllable in brightness (through pwm)
in 256 steps so that RGB LEDs can show any of ca. 16 Mio colors.
The maximum current of the LED
14 matches
Mail list logo
