Re: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-18 Thread Joe Perches
On Mon, 2014-08-18 at 08:45 -0700, Alexander Duyck wrote: > On 08/18/2014 08:31 AM, Joe Perches wrote: > > On Mon, 2014-08-18 at 08:29 -0700, Alexander Duyck wrote: > >> Doing any kind of pointer math on a void pointer is generally unsafe as > >> it is an incomplete type. The only reason why it wo

Re: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-18 Thread Alexander Duyck
On 08/18/2014 08:31 AM, Joe Perches wrote: > On Mon, 2014-08-18 at 08:29 -0700, Alexander Duyck wrote: >> Doing any kind of pointer math on a void pointer is generally unsafe as >> it is an incomplete type. The only reason why it works in GCC is >> because GCC has a nonstandard extension that make

Re: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-18 Thread Krzysztof Majzerowicz-Jaszcz
On 18/08/14 17:40, Joe Perches wrote: > On Mon, 2014-08-18 at 17:36 +0200, Krzysztof Majzerowicz-Jaszcz wrote: >> On 18/08/14 17:31, Joe Perches wrote: >>> On Mon, 2014-08-18 at 08:29 -0700, Alexander Duyck wrote: Doing any kind of pointer math on a void pointer is generally unsafe as it

Re: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-18 Thread Joe Perches
On Mon, 2014-08-18 at 17:36 +0200, Krzysztof Majzerowicz-Jaszcz wrote: > On 18/08/14 17:31, Joe Perches wrote: > > On Mon, 2014-08-18 at 08:29 -0700, Alexander Duyck wrote: > >> Doing any kind of pointer math on a void pointer is generally unsafe as > >> it is an incomplete type. The only reason w

Re: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-18 Thread Joe Perches
On Mon, 2014-08-18 at 08:29 -0700, Alexander Duyck wrote: > Doing any kind of pointer math on a void pointer is generally unsafe as > it is an incomplete type. The only reason why it works in GCC is > because GCC has a nonstandard extension that makes it report as having a > size of 1. I know. I

Re: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-18 Thread Krzysztof Majzerowicz-Jaszcz
On 18/08/14 17:31, Joe Perches wrote: > On Mon, 2014-08-18 at 08:29 -0700, Alexander Duyck wrote: >> Doing any kind of pointer math on a void pointer is generally unsafe as >> it is an incomplete type. The only reason why it works in GCC is >> because GCC has a nonstandard extension that makes it

Re: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-18 Thread Alexander Duyck
On 08/16/2014 11:41 AM, Joe Perches wrote: > On Sat, 2014-08-16 at 11:12 +0200, Krzysztof Majzerowicz-Jaszcz wrote: >> @@ -1835,11 +1830,11 @@ static void e1000_get_ethtool_stats(struct >> net_device *netdev, >> for (i = 0; i < E1000_GLOBAL_STATS_LEN; i++) { >> switch (e1000_gstr

Re: [PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-16 Thread Joe Perches
On Sat, 2014-08-16 at 11:12 +0200, Krzysztof Majzerowicz-Jaszcz wrote: > Fixed many errors/warnings and checks in e1000_ethtool.c reported by > checkpatch.pl Hello Krzysztof. Just some trivial notes: > diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c > b/drivers/net/ethernet/intel

[PATCH] drivers: net: ethernet: intel: e1000: e1000_ethtool.c coding style fixes

2014-08-16 Thread Krzysztof Majzerowicz-Jaszcz
Fixed many errors/warnings and checks in e1000_ethtool.c reported by checkpatch.pl Signed-off-by: Krzysztof Majzerowicz-Jaszcz --- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 135 +++ 1 file changed, 65 insertions(+), 70 deletions(-) diff --git a/drivers/net/ethernet