Re: [PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-26 Thread David Miller
From: Iyappan Subramanian Date: Mon, 26 Jan 2015 13:12:23 -0800 >>> @@ -369,6 +369,8 @@ static int xgene_enet_process_ring(struct >>> xgene_enet_desc_ring *ring, >>> if (unlikely(xgene_enet_is_desc_slot_empty(raw_desc))) >>> break; >>> >>> + /* rea

Re: [PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-26 Thread Eric Dumazet
On Mon, 2015-01-26 at 13:27 -0800, Eric Dumazet wrote: > What happens if you compile a kernel with CONFIG_SMP=n ? > > > Most drivers in drivers/net use rmb() in this case, not smp_rmb() or > barrier() Note that dma_rmb() was recently added as well. -- To unsubscribe from this list: send the

Re: [PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-26 Thread Eric Dumazet
On Mon, 2015-01-26 at 13:12 -0800, Iyappan Subramanian wrote: > On Thu, Jan 22, 2015 at 2:50 PM, Eric Dumazet wrote: > > On Thu, 2015-01-22 at 12:03 -0800, Iyappan Subramanian wrote: > >> This patch fixes the following kernel crash, > >> > >> WARNING: CPU: 2 PID: 0 at net/ipv4/tcp_input.c:30

Re: [PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-26 Thread Iyappan Subramanian
On Thu, Jan 22, 2015 at 2:50 PM, Eric Dumazet wrote: > On Thu, 2015-01-22 at 12:03 -0800, Iyappan Subramanian wrote: >> This patch fixes the following kernel crash, >> >> WARNING: CPU: 2 PID: 0 at net/ipv4/tcp_input.c:3079 >> tcp_clean_rtx_queue+0x658/0x80c() >> Call trace: > >> >> So

Re: [PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-22 Thread Eric Dumazet
On Thu, 2015-01-22 at 12:03 -0800, Iyappan Subramanian wrote: > This patch fixes the following kernel crash, > > WARNING: CPU: 2 PID: 0 at net/ipv4/tcp_input.c:3079 > tcp_clean_rtx_queue+0x658/0x80c() > Call trace: > > Software writes poison data into the descriptor bytes[15:8] and

[PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-22 Thread Iyappan Subramanian
This patch fixes the following kernel crash, WARNING: CPU: 2 PID: 0 at net/ipv4/tcp_input.c:3079 tcp_clean_rtx_queue+0x658/0x80c() Call trace: [] dump_backtrace+0x0/0x184 [] show_stack+0x10/0x1c [] dump_stack+0x74/0x98 [] warn_slowpath_common+0x88/0