Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-09-04 Thread Arnd Bergmann
On Thursday 04 September 2014 17:02:17 Lorenzo Pieralisi wrote: > On Thu, Sep 04, 2014 at 03:05:53PM +0100, Arnd Bergmann wrote: > > Interesting point: the generic implementation should probably not default > > to reassigning all buses at all. We could have a (host controller specific, > > but wit

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-09-04 Thread Lorenzo Pieralisi
Hi Arnd, thanks for having a look. On Thu, Sep 04, 2014 at 03:05:53PM +0100, Arnd Bergmann wrote: > On Thursday 04 September 2014 14:39:56 Lorenzo Pieralisi wrote: > > > > + if (!res_valid) { > > > > + dev_err(dev, "non-prefetchable memory resource required\n"); > > > > + re

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-09-04 Thread Arnd Bergmann
On Thursday 04 September 2014 14:39:56 Lorenzo Pieralisi wrote: > > > + if (!res_valid) { > > > + dev_err(dev, "non-prefetchable memory resource required\n"); > > > + return -EINVAL; > > > + } > > > + > > > + if (iores) { > > > + if (!PAGE_ALIGNED(io_cpuaddr)) >

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-09-04 Thread Lorenzo Pieralisi
Hi Will, sorry for the delay in replying (I was not copied in). On Tue, Aug 19, 2014 at 01:05:54PM +0100, Will Deacon wrote: > Hi guys, > > On Tue, Aug 12, 2014 at 05:41:35PM +0100, Liviu Dudau wrote: > > From: Lorenzo Pieralisi > > > > In order to consolidate DT configuration for PCI host con

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-22 Thread Bjorn Helgaas
On Fri, Aug 22, 2014 at 7:32 AM, Liviu Dudau wrote: > On Fri, Aug 22, 2014 at 12:13:33AM -0500, Bjorn Helgaas wrote: >> On Thu, Aug 21, 2014 at 6:01 PM, Liviu Dudau wrote: >> > On Thu, Aug 21, 2014 at 12:02:16PM -0600, Bjorn Helgaas wrote: >> >> [+cc Lorenzo] >> >> >> >> On Wed, Aug 20, 2014 at 0

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-22 Thread Liviu Dudau
On Fri, Aug 22, 2014 at 12:13:33AM -0500, Bjorn Helgaas wrote: > On Thu, Aug 21, 2014 at 6:01 PM, Liviu Dudau wrote: > > On Thu, Aug 21, 2014 at 12:02:16PM -0600, Bjorn Helgaas wrote: > >> [+cc Lorenzo] > >> > >> On Wed, Aug 20, 2014 at 05:35:59PM -0500, Bjorn Helgaas wrote: > >> > On Wed, Aug 20,

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-21 Thread Bjorn Helgaas
On Thu, Aug 21, 2014 at 6:01 PM, Liviu Dudau wrote: > On Thu, Aug 21, 2014 at 12:02:16PM -0600, Bjorn Helgaas wrote: >> [+cc Lorenzo] >> >> On Wed, Aug 20, 2014 at 05:35:59PM -0500, Bjorn Helgaas wrote: >> > On Wed, Aug 20, 2014 at 7:31 AM, Liviu Dudau wrote: >> > > On Wed, Aug 20, 2014 at 01:27:

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-21 Thread Liviu Dudau
On Wed, Aug 20, 2014 at 09:39:27PM +0200, Arnd Bergmann wrote: > On Wednesday 20 August 2014, Liviu Dudau wrote: > > That has been the general approach of my patchset up to v9. But, as Bjorn > > has > > mentioned in his v8 review and I have put in my cover letter, the regular > > aproach means tha

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-21 Thread Liviu Dudau
On Thu, Aug 21, 2014 at 12:02:16PM -0600, Bjorn Helgaas wrote: > [+cc Lorenzo] > > On Wed, Aug 20, 2014 at 05:35:59PM -0500, Bjorn Helgaas wrote: > > On Wed, Aug 20, 2014 at 7:31 AM, Liviu Dudau wrote: > > > On Wed, Aug 20, 2014 at 01:27:57PM +0200, Arnd Bergmann wrote: > > >> On Tuesday 12 Augus

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-21 Thread Liviu Dudau
On Thu, Aug 21, 2014 at 12:02:16PM -0600, Bjorn Helgaas wrote: > [+cc Lorenzo] > > On Wed, Aug 20, 2014 at 05:35:59PM -0500, Bjorn Helgaas wrote: > > On Wed, Aug 20, 2014 at 7:31 AM, Liviu Dudau wrote: > > > On Wed, Aug 20, 2014 at 01:27:57PM +0200, Arnd Bergmann wrote: > > >> On Tuesday 12 Augus

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-21 Thread Bjorn Helgaas
[+cc Lorenzo] On Wed, Aug 20, 2014 at 05:35:59PM -0500, Bjorn Helgaas wrote: > On Wed, Aug 20, 2014 at 7:31 AM, Liviu Dudau wrote: > > On Wed, Aug 20, 2014 at 01:27:57PM +0200, Arnd Bergmann wrote: > >> On Tuesday 12 August 2014, Liviu Dudau wrote: > >> > + return of_create_pci_host_bridge(

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-20 Thread Bjorn Helgaas
On Wed, Aug 20, 2014 at 7:31 AM, Liviu Dudau wrote: > On Wed, Aug 20, 2014 at 01:27:57PM +0200, Arnd Bergmann wrote: >> On Tuesday 12 August 2014, Liviu Dudau wrote: >> > + return of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops, >> > + gen_pci_setup

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-20 Thread Arnd Bergmann
On Wednesday 20 August 2014, Liviu Dudau wrote: > That has been the general approach of my patchset up to v9. But, as Bjorn has > mentioned in his v8 review and I have put in my cover letter, the regular > aproach means that architectures that use pci_scan_root_bus() will have to > drop their one l

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-20 Thread Liviu Dudau
On Wed, Aug 20, 2014 at 01:27:57PM +0200, Arnd Bergmann wrote: > On Tuesday 12 August 2014, Liviu Dudau wrote: > > + return of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops, > > + gen_pci_setup, pci); > > I had not noticed it earlier, but the setup c

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-20 Thread Arnd Bergmann
On Tuesday 12 August 2014, Liviu Dudau wrote: > + return of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops, > + gen_pci_setup, pci); I had not noticed it earlier, but the setup callback is actually a feature of the arm32 PCI code that I had hoped to a

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-20 Thread Arnd Bergmann
On Tuesday 19 August 2014, Will Deacon wrote: > On Tue, Aug 12, 2014 at 05:41:35PM +0100, Liviu Dudau wrote: > > + if (!res_valid) { > > + dev_err(dev, "non-prefetchable memory resource required\n"); > > + return -EINVAL; > > + } I don't see why this part should be

Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-19 Thread Will Deacon
Hi guys, On Tue, Aug 12, 2014 at 05:41:35PM +0100, Liviu Dudau wrote: > From: Lorenzo Pieralisi > > In order to consolidate DT configuration for PCI host controllers in the > kernel, a new API was introduced that allows creating a host bridge > and its PCI bus from DT, removing duplicated code p

[PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

2014-08-12 Thread Liviu Dudau
From: Lorenzo Pieralisi In order to consolidate DT configuration for PCI host controllers in the kernel, a new API was introduced that allows creating a host bridge and its PCI bus from DT, removing duplicated code present in the majority of pci host driver implementations. This patch converts t