Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c

2013-12-19 Thread Richard Cochran
On Thu, Dec 19, 2013 at 07:13:20PM +, Ben Hutchings wrote: > > PTP is no longer a compile-time option in most net drivers. Right, for those drivers where there is little or no performance impact, there is no good reason not to enable the PTP bits. But if the PTP code entails a run time cost,

Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c

2013-12-19 Thread Ben Hutchings
On Thu, 2013-12-19 at 08:27 +0100, Richard Cochran wrote: > On Wed, Dec 18, 2013 at 05:43:59PM -0500, David Miller wrote: > > > > I think this begs an even more fundamental question, why isn't the PTP > > driver abstraction providing the necessary methods and interfaces so > > that pch_gbe doesn't

Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c

2013-12-18 Thread Richard Cochran
On Wed, Dec 18, 2013 at 05:43:59PM -0500, David Miller wrote: > > I think this begs an even more fundamental question, why isn't the PTP > driver abstraction providing the necessary methods and interfaces so > that pch_gbe doesn't have to call into the ptp_pch.c code directly? Really it is more o

Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c

2013-12-18 Thread josh
On Wed, Dec 18, 2013 at 05:43:59PM -0500, David Miller wrote: > From: Richard Cochran > Date: Mon, 16 Dec 2013 09:58:40 +0100 > > > On Mon, Dec 16, 2013 at 02:14:15AM +0530, Rashika Kheria wrote: > >> --- > >> drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h|9 - > >> .../net/ethe

Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c

2013-12-18 Thread David Miller
From: Richard Cochran Date: Mon, 16 Dec 2013 09:58:40 +0100 > On Mon, Dec 16, 2013 at 02:14:15AM +0530, Rashika Kheria wrote: >> --- >> drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h|9 - >> .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c |1 + >> drivers/ptp/ptp_pch.c

Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c

2013-12-16 Thread Richard Cochran
On Mon, Dec 16, 2013 at 02:14:15AM +0530, Rashika Kheria wrote: > --- > drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h|9 - > .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c |1 + > drivers/ptp/ptp_pch.c |1 + > include/linux/ptp_pch.h

Re: [PATCH] drivers: ptp: Include new header file in ptp_pch.c

2013-12-15 Thread Josh Triplett
On Mon, Dec 16, 2013 at 02:14:15AM +0530, Rashika Kheria wrote: > Create a new header file include/linux/ptp_pch.h which contains > prototype declaration of functions pch_ch_control_read(), > pch_ch_control_write(), pch_ch_event_read(), pch_ch_event_write(), > pch_src_uuid_lo_read(), pch_src_uuid_h

[PATCH] drivers: ptp: Include new header file in ptp_pch.c

2013-12-15 Thread Rashika Kheria
Create a new header file include/linux/ptp_pch.h which contains prototype declaration of functions pch_ch_control_read(), pch_ch_control_write(), pch_ch_event_read(), pch_ch_event_write(), pch_src_uuid_lo_read(), pch_src_uuid_hi_read(), pch_rx_snap_read(), pch_tx_snap_read() and pch_set_station_add