Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-03 Thread Chen Gang
On 12/03/2013 05:32 AM, rkuo wrote: > On Mon, Dec 02, 2013 at 06:14:33PM +0800, Chen Gang wrote: >> If one issue occurs, normally, both sides need improvement. >> >> For our issue: >> >> - need try to keep uapi no touch ("arch/hexagon/uapi/asm/registers.h"). >> >> - improving our module is much e

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-02 Thread rkuo
On Mon, Dec 02, 2013 at 06:14:33PM +0800, Chen Gang wrote: > If one issue occurs, normally, both sides need improvement. > > For our issue: > > - need try to keep uapi no touch ("arch/hexagon/uapi/asm/registers.h"). > > - improving our module is much easier than improving hexagon. > > - for

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-02 Thread Chen Gang
On 12/02/2013 08:49 AM, James Bottomley wrote: > On Mon, 2013-12-02 at 08:34 +0800, Chen Gang wrote: >> On 12/02/2013 12:17 AM, Bart Van Assche wrote: >>> On 11/27/13 03:29, Chen Gang wrote: the macro "SP" is too common to make conflict with some architectures, so recommend to add prefix

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-01 Thread James Bottomley
On Mon, 2013-12-02 at 08:34 +0800, Chen Gang wrote: > On 12/02/2013 12:17 AM, Bart Van Assche wrote: > > On 11/27/13 03:29, Chen Gang wrote: > >> the macro "SP" is too common to make conflict with some architectures, > >> so recommend to add prefix for it. > >> > >> The related warning (with allmod

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-01 Thread Chen Gang
On 12/02/2013 12:17 AM, Bart Van Assche wrote: > On 11/27/13 03:29, Chen Gang wrote: >> the macro "SP" is too common to make conflict with some architectures, >> so recommend to add prefix for it. >> >> The related warning (with allmodconfig for hexagon): >> >> CC [M] drivers/scsi/scsi_lib.o >

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-01 Thread Bart Van Assche
On 11/27/13 03:29, Chen Gang wrote: > the macro "SP" is too common to make conflict with some architectures, > so recommend to add prefix for it. > > The related warning (with allmodconfig for hexagon): > > CC [M] drivers/scsi/scsi_lib.o > drivers/scsi/scsi_lib.c:46:0: warning: "SP" redefi

[PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-11-26 Thread Chen Gang
the macro "SP" is too common to make conflict with some architectures, so recommend to add prefix for it. The related warning (with allmodconfig for hexagon): CC [M] drivers/scsi/scsi_lib.o drivers/scsi/scsi_lib.c:46:0: warning: "SP" redefined [enabled by default] arch/hexagon/include/ua