Re: [PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function

2014-08-11 Thread Oleg Drokin
On Aug 11, 2014, at 9:58 PM, Oleg Drokin wrote: > > On Aug 10, 2014, at 12:34 AM, Greg KH wrote: >> Very odd, with this patch applied, I now get a build warning: >> >> drivers/staging/lustre/lnet/lnet/config.c: In function ‘lnet_parse_ip2nets’: >> drivers/staging/lustre/lnet/lnet/config.c:1193:

Re: [PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function

2014-08-11 Thread Drokin, Oleg
On Aug 10, 2014, at 12:34 AM, Greg KH wrote: > Very odd, with this patch applied, I now get a build warning: > > drivers/staging/lustre/lnet/lnet/config.c: In function ‘lnet_parse_ip2nets’: > drivers/staging/lustre/lnet/lnet/config.c:1193:2: warning: ‘ipaddrs’ may be > used uninitialized in this

Re: [PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function

2014-08-10 Thread Greg KH
On Fri, Aug 08, 2014 at 06:26:22PM +0200, Benedict Boerger wrote: > drivers: staging: lustre: fix sparse warning: symbol XYZ was > not declared. Should it be static? > > This was done by declaring them static. This could be done because the > functions > were used only in this file. > > Deleted

[PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function

2014-08-08 Thread Benedict Boerger
drivers: staging: lustre: fix sparse warning: symbol XYZ was not declared. Should it be static? This was done by declaring them static. This could be done because the functions were used only in this file. Deleted the function lnet_print_text_bufs because it were unused. Compiled without an erro