Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-10 Thread Chen Gang
On 01/10/2014 01:47 PM, Nicholas A. Bellinger wrote: > On Thu, 2014-01-09 at 11:17 +0100, Hannes Reinecke wrote: >> On 01/09/2014 12:18 AM, Nicholas A. Bellinger wrote: >>> On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: > > > Other than that the sector_div() patch is correct.

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-10 Thread Chen Gang
On 01/10/2014 01:47 PM, Nicholas A. Bellinger wrote: On Thu, 2014-01-09 at 11:17 +0100, Hannes Reinecke wrote: On 01/09/2014 12:18 AM, Nicholas A. Bellinger wrote: On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: SNIP Other than that the sector_div() patch is correct. nod

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-09 Thread Nicholas A. Bellinger
On Thu, 2014-01-09 at 11:17 +0100, Hannes Reinecke wrote: > On 01/09/2014 12:18 AM, Nicholas A. Bellinger wrote: > > On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: > >> Other than that the sector_div() patch is correct. > >> > > > > Thanks for confirming that sector_div() is correct

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-09 Thread Hannes Reinecke
On 01/09/2014 12:18 AM, Nicholas A. Bellinger wrote: On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: On 12/24/2013 04:35 AM, Chen Gang wrote: On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: The related fix patch changed

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-09 Thread Hannes Reinecke
On 01/09/2014 12:18 AM, Nicholas A. Bellinger wrote: On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: On 12/24/2013 04:35 AM, Chen Gang wrote: On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: SNIP The related fix patch

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-09 Thread Nicholas A. Bellinger
On Thu, 2014-01-09 at 11:17 +0100, Hannes Reinecke wrote: On 01/09/2014 12:18 AM, Nicholas A. Bellinger wrote: On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: SNIP Other than that the sector_div() patch is correct. nod Thanks for confirming that sector_div() is correct here

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-08 Thread Nicholas A. Bellinger
On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: > On 12/24/2013 04:35 AM, Chen Gang wrote: > > On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: > >> On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: > >>> The related fix patch changed "start_lba = lba % ..." to "start_lba = >

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-08 Thread Chen Gang
On 01/08/2014 03:32 PM, Hannes Reinecke wrote: > On 12/24/2013 04:35 AM, Chen Gang wrote: >> On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: >>> On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: > Hi Chen, > > On Sat,

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-08 Thread Chen Gang
On 01/08/2014 03:32 PM, Hannes Reinecke wrote: On 12/24/2013 04:35 AM, Chen Gang wrote: On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: Hi Chen, On Sat, 2013-12-21 at 10:08 +0800,

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-08 Thread Nicholas A. Bellinger
On Wed, 2014-01-08 at 08:32 +0100, Hannes Reinecke wrote: On 12/24/2013 04:35 AM, Chen Gang wrote: On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: SNIP The related fix patch changed start_lba = lba % ... to start_lba = lba / ...,

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-07 Thread Hannes Reinecke
On 12/24/2013 04:35 AM, Chen Gang wrote: > On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: >> On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: >>> On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: Hi Chen, On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: > In

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-07 Thread Hannes Reinecke
On 12/24/2013 04:35 AM, Chen Gang wrote: On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: Hi Chen, On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: In kernel, need use

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-23 Thread Chen Gang
On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: > On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: >> On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: >>> Hi Chen, >>> >>> On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: In kernel, need use div64_u64_rem() instead of operator

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-23 Thread Chen Gang
On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: Hi Chen, On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: In kernel, need use div64_u64_rem() instead of operator '%' for u64, or

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-22 Thread Nicholas A. Bellinger
On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: > On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: > > Hi Chen, > > > > On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: > >> In kernel, need use div64_u64_rem() instead of operator '%' for u64, or > >> can not pass compiling (with

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-22 Thread Chen Gang
On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: > Hi Chen, > > On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: >> In kernel, need use div64_u64_rem() instead of operator '%' for u64, or >> can not pass compiling (with allmodconfig under metag): >> >> MODPOST 2909 modules >> ERROR:

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-22 Thread Chen Gang
On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: Hi Chen, On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: In kernel, need use div64_u64_rem() instead of operator '%' for u64, or can not pass compiling (with allmodconfig under metag): MODPOST 2909 modules ERROR: __umoddi3

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-22 Thread Nicholas A. Bellinger
On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: Hi Chen, On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: In kernel, need use div64_u64_rem() instead of operator '%' for u64, or can not pass compiling (with allmodconfig under

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-21 Thread Nicholas A. Bellinger
Hi Chen, On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: > In kernel, need use div64_u64_rem() instead of operator '%' for u64, or > can not pass compiling (with allmodconfig under metag): > > MODPOST 2909 modules > ERROR: "__umoddi3" [drivers/target/target_core_mod.ko] undefined! > >

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-21 Thread Nicholas A. Bellinger
Hi Chen, On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: In kernel, need use div64_u64_rem() instead of operator '%' for u64, or can not pass compiling (with allmodconfig under metag): MODPOST 2909 modules ERROR: __umoddi3 [drivers/target/target_core_mod.ko] undefined! Also

[PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-20 Thread Chen Gang
In kernel, need use div64_u64_rem() instead of operator '%' for u64, or can not pass compiling (with allmodconfig under metag): MODPOST 2909 modules ERROR: "__umoddi3" [drivers/target/target_core_mod.ko] undefined! Also need u64 type cast for u32 variable multiply u32 variable, or will

[PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-20 Thread Chen Gang
In kernel, need use div64_u64_rem() instead of operator '%' for u64, or can not pass compiling (with allmodconfig under metag): MODPOST 2909 modules ERROR: __umoddi3 [drivers/target/target_core_mod.ko] undefined! Also need u64 type cast for u32 variable multiply u32 variable, or will cause