Re: [PATCH] drivers: usb: gadget: prefer pr_*() functions over raw printk()

2020-12-10 Thread Enrico Weigelt, metux IT consult
On 09.12.20 12:27, Laurent Pinchart wrote: Hi, >>> I wonder if this shouldn't be dropped instead, commented-out code isn't >>> very useful. >> >> Indeed. Shall I send a separate patch for that ? > > Yes, that would make sense. Okay, I'm currently doing a more in-depth rework. I'll send another

Re: [PATCH] drivers: usb: gadget: prefer pr_*() functions over raw printk()

2020-12-09 Thread Laurent Pinchart
Hi Enrico, On Wed, Dec 09, 2020 at 12:11:36PM +0100, Enrico Weigelt, metux IT consult wrote: > On 08.12.20 16:54, Laurent Pinchart wrote: > >> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c > >> b/drivers/usb/gadget/udc/atmel_usba_udc.c > >> index 2b893bceea45..4834fafb3f70 100644 > >>

Re: [PATCH] drivers: usb: gadget: prefer pr_*() functions over raw printk()

2020-12-09 Thread Enrico Weigelt, metux IT consult
On 08.12.20 16:54, Laurent Pinchart wrote: Hi, >> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c >> b/drivers/usb/gadget/udc/atmel_usba_udc.c >> index 2b893bceea45..4834fafb3f70 100644 >> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c >> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c >> @@

Re: [PATCH] drivers: usb: gadget: prefer pr_*() functions over raw printk()

2020-12-08 Thread Peter Chen
On 20-12-08 15:44:03, Enrico Weigelt, metux IT consult wrote: > Reduce a bit logging boilerplate by using the preferred pr_*() > macros instead of raw printk(). It is the device driver code, it is better to use dev_info/dev_dbg. Peter > > Signed-off-by: Enrico Weigelt, metux IT consult > --- >

Re: [PATCH] drivers: usb: gadget: prefer pr_*() functions over raw printk()

2020-12-08 Thread Laurent Pinchart
Hi Enrico, Thank you for the patch. On Tue, Dec 08, 2020 at 03:44:03PM +0100, Enrico Weigelt, metux IT consult wrote: > Reduce a bit logging boilerplate by using the preferred pr_*() > macros instead of raw printk(). > > Signed-off-by: Enrico Weigelt, metux IT consult > --- >

[PATCH] drivers: usb: gadget: prefer pr_*() functions over raw printk()

2020-12-08 Thread Enrico Weigelt, metux IT consult
Reduce a bit logging boilerplate by using the preferred pr_*() macros instead of raw printk(). Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/usb/gadget/function/uvc.h | 2 +- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- drivers/usb/gadget/udc/fsl_udc_core.c | 4 +--