Re: [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Guenter Roeck
[ ... ] > The R8610-G datasheet is the one that I have had and used thus far. > Mine is draft version 0.2. Do you have a newer version, by any chance ? >> Unfortunately, none of those >> describes the use of bit(31) in the watchdog register, nor the meaning >> of bit(12) and bit(13). Bit(31) is

Re: [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Florian Fainelli
On 8/7/2020 4:23 PM, Guenter Roeck wrote: > Hi Florian, > > On 8/7/20 1:09 PM, Florian Fainelli wrote: >> >> On 8/7/2020 12:08 PM, Guenter Roeck wrote: >>> On 8/7/20 11:08 AM, Florian Fainelli wrote: On 8/7/2020 9:21 AM, Guenter Roeck wrote: > On Fri, Aug 07, 2020 at

Re: [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Guenter Roeck
Hi Florian, On 8/7/20 1:09 PM, Florian Fainelli wrote: > > On 8/7/2020 12:08 PM, Guenter Roeck wrote: >> On 8/7/20 11:08 AM, Florian Fainelli wrote: >>> >>> >>> On 8/7/2020 9:21 AM, Guenter Roeck wrote: On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmi...@gmail.com wrote:

Re: [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Florian Fainelli
On 8/7/2020 12:08 PM, Guenter Roeck wrote: > On 8/7/20 11:08 AM, Florian Fainelli wrote: >> >> >> On 8/7/2020 9:21 AM, Guenter Roeck wrote: >>> On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmi...@gmail.com >>> wrote: From: Madhuparna Bhowmik In rdc321x_wdt_probe(),

Re: [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Guenter Roeck
On 8/7/20 11:08 AM, Florian Fainelli wrote: > > > On 8/7/2020 9:21 AM, Guenter Roeck wrote: >> On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmi...@gmail.com >> wrote: >>> From: Madhuparna Bhowmik >>> >>> In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized >>> after

Re: [ldv-project] [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Guenter Roeck
On 8/7/20 11:30 AM, Evgeny Novikov wrote: > 07.08.2020, 19:21, "Guenter Roeck" : >> On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmi...@gmail.com >> wrote: >>>  From: Madhuparna Bhowmik >>> >>>  In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized >>>  after misc_register(),

Re: [ldv-project] [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Evgeny Novikov
07.08.2020, 19:21, "Guenter Roeck" : > On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmi...@gmail.com wrote: >>  From: Madhuparna Bhowmik >> >>  In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized >>  after misc_register(), hence if ioctl is called before its >>  

Re: [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Guenter Roeck
On 8/7/20 11:08 AM, Florian Fainelli wrote: > > > On 8/7/2020 9:21 AM, Guenter Roeck wrote: >> On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmi...@gmail.com >> wrote: >>> From: Madhuparna Bhowmik >>> >>> In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized >>> after

Re: [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Florian Fainelli
On 8/7/2020 9:21 AM, Guenter Roeck wrote: > On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmi...@gmail.com wrote: >> From: Madhuparna Bhowmik >> >> In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized >> after misc_register(), hence if ioctl is called before its >>

Re: [PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread Guenter Roeck
On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmi...@gmail.com wrote: > From: Madhuparna Bhowmik > > In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized > after misc_register(), hence if ioctl is called before its > initialization which can call rdc321x_wdt_start() function,

[PATCH] drivers: watchdog: rdc321x_wdt: Fix race condition bugs

2020-08-07 Thread madhuparnabhowmik10
From: Madhuparna Bhowmik In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized after misc_register(), hence if ioctl is called before its initialization which can call rdc321x_wdt_start() function, it will see an uninitialized value of rdc321x_wdt_device.queue, hence initialize it