Re: [PATCH] drivers:atm Remove two FIXMES in the function, top_off_fp for the file, firestream.c

2014-12-08 Thread chas williams - CONTRACTOR
I don't see any reason to promote qe_tmp to a u64. I think you can just remove the comment. Anyone trying to build this into a 64-bit kernel will see errors from the virt_to_bus()/bus_to_virt() usage. fp->n seems to only be manipulated in interrupt context (after driving initialization) so it

Re: [PATCH] drivers:atm Remove two FIXMES in the function, top_off_fp for the file, firestream.c

2014-12-08 Thread chas williams - CONTRACTOR
I don't see any reason to promote qe_tmp to a u64. I think you can just remove the comment. Anyone trying to build this into a 64-bit kernel will see errors from the virt_to_bus()/bus_to_virt() usage. fp-n seems to only be manipulated in interrupt context (after driving initialization) so it