Re: [PATCH] drm/amdgpu: allocate large structures dynamically

2020-05-07 Thread Joe Perches
On Thu, 2020-05-07 at 08:42 +0200, Christian König wrote: > Am 06.05.20 um 21:01 schrieb Joe Perches: [] > > And trivia: > > > > The !! uses with bool seem unnecessary and it's probably better > > to make amdgpu_ras_is_feature_enabled to return bool. [] > > diff --git

Re: [PATCH] drm/amdgpu: allocate large structures dynamically

2020-05-07 Thread Christian König
Am 06.05.20 um 21:01 schrieb Joe Perches: On Tue, 2020-05-05 at 16:01 +0200, Arnd Bergmann wrote: After the structure was padded to 1024 bytes, it is no longer suitable for being a local variable, as the function surpasses the warning limit for 32-bit architectures:

Re: [PATCH] drm/amdgpu: allocate large structures dynamically

2020-05-06 Thread Joe Perches
On Tue, 2020-05-05 at 16:01 +0200, Arnd Bergmann wrote: > After the structure was padded to 1024 bytes, it is no longer > suitable for being a local variable, as the function surpasses > the warning limit for 32-bit architectures: > > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:587:5: error: stack

Re: [PATCH] drm/amdgpu: allocate large structures dynamically

2020-05-05 Thread Alex Deucher
On Tue, May 5, 2020 at 10:07 AM Christian König wrote: > > Am 05.05.20 um 16:01 schrieb Arnd Bergmann: > > After the structure was padded to 1024 bytes, it is no longer > > suitable for being a local variable, as the function surpasses > > the warning limit for 32-bit architectures: > > > >

Re: [PATCH] drm/amdgpu: allocate large structures dynamically

2020-05-05 Thread Christian König
Am 05.05.20 um 16:01 schrieb Arnd Bergmann: After the structure was padded to 1024 bytes, it is no longer suitable for being a local variable, as the function surpasses the warning limit for 32-bit architectures: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:587:5: error: stack frame size of 1072

[PATCH] drm/amdgpu: allocate large structures dynamically

2020-05-05 Thread Arnd Bergmann
After the structure was padded to 1024 bytes, it is no longer suitable for being a local variable, as the function surpasses the warning limit for 32-bit architectures: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:587:5: error: stack frame size of 1072 bytes in function 'amdgpu_ras_feature_enable'