Re: [PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Daniel Vetter
> > From: Nicolai Stange [mailto:nicsta...@gmail.com] > > > Sent: Monday, December 05, 2016 3:30 PM > > > To: Daniel Vetter > > > Cc: Deucher, Alexander; Koenig, Christian; Michel Dänzer; linux- > > > ker...@vger.kernel.org; dri-de...@lists.freedesktop.org; N

Re: [PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Daniel Vetter
[mailto:nicsta...@gmail.com] > > > Sent: Monday, December 05, 2016 3:30 PM > > > To: Daniel Vetter > > > Cc: Deucher, Alexander; Koenig, Christian; Michel Dänzer; linux- > > > ker...@vger.kernel.org; dri-de...@lists.freedesktop.org; Nicolai Stange > > > S

RE: [PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Deucher, Alexander
i Stange > Subject: [PATCH] drm/amdgpu: don't add files at control minor debugfs > directory > > Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > struct drm_device's ->control member is always NULL. > > In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_a

RE: [PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Deucher, Alexander
i Stange > Subject: [PATCH] drm/amdgpu: don't add files at control minor debugfs > directory > > Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a > struct drm_device's ->control member is always NULL. > > In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_a

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Nicolai Stange
Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_add_files() accesses ->control->debugfs_root though. This results in a NULL pointer dereference. Fix this by omitting the

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Nicolai Stange
Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_add_files() accesses ->control->debugfs_root though. This results in a NULL pointer dereference. Fix this by omitting the