Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-10-17 Thread Sam Ravnborg
Hi Vinay On Tue, Sep 08, 2020 at 08:57:07PM +0300, Laurent Pinchart wrote: > Hi Vinay, > > On Tue, Sep 08, 2020 at 11:22:48PM +0530, Vinay Simha B N wrote: > > laurent, > > > > Please review or give some feedback. > > I'm sorry, I have very little time these days :-( Maybe Neil can provide >

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-09-08 Thread Laurent Pinchart
Hi Vinay, On Tue, Sep 08, 2020 at 11:22:48PM +0530, Vinay Simha B N wrote: > laurent, > > Please review or give some feedback. I'm sorry, I have very little time these days :-( Maybe Neil can provide feedback ? > On Tue, Aug 25, 2020 at 7:57 PM Vinay Simha B N wrote: > > > laurent, > > > >

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-25 Thread Vinay Simha B N
laurent, Please review or give some feedback. On Thu, Aug 13, 2020 at 9:09 PM Vinay Simha B N wrote: > > laurent, > > The code sequence was a problem. *num_inputs_fmts = > ARRAY_SIZE(tc_lvds_in_bus_fmts); should come first and then allocate > the kcalloc. > > input_fmts =

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-13 Thread Vinay Simha B N
laurent, The code sequence was a problem. *num_inputs_fmts = ARRAY_SIZE(tc_lvds_in_bus_fmts); should come first and then allocate the kcalloc. input_fmts = kcalloc(*num_input_fmts, ARRAY_SIZE(tc_lvds_in_bus_fmts), GFP_KERNEL); .. for (i = 0; i <

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Vinay Simha B N
laurent, if i add the .atomic_get_input_bus_fmts = tc_bridge_get_input_bus_fmts, with the implementation suggested, system does not boot fully, the reason is, we capture all the supported input formats, but not sure where to set the final input format. Please suggest. for (i = 0; i <

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Vinay Simha B N
laurent, Video data input format : RGB666 loosely packed 24 bits per pixel Can we use MEDIA_BUS_FMT_RGB666_1X24_CPADHI? There was no information wrt CPADHI or for loosely packed static const u32 tc_lvds_in_bus_fmts[] = { MEDIA_BUS_FMT_RGB565_1X16, MEDIA_BUS_FMT_RGB666_1X18,

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Laurent Pinchart
Hi Vinay, On Wed, Aug 12, 2020 at 06:07:52PM +0530, Vinay Simha B N wrote: > On Wed, Aug 12, 2020 at 3:24 PM Laurent Pinchart wrote: > > On Wed, Aug 12, 2020 at 12:55:50PM +0530, Vinay Simha BN wrote: > > > - bus formats read from drm_bridge_state.output_bus_cfg.format > > > and

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Vinay Simha B N
laurent, please see the reply inline below. On Wed, Aug 12, 2020 at 3:24 PM Laurent Pinchart wrote: > > Hi Vinay, > > Thank you for the patch. > > On Wed, Aug 12, 2020 at 12:55:50PM +0530, Vinay Simha BN wrote: > > - bus formats read from drm_bridge_state.output_bus_cfg.format > > and

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Laurent Pinchart
Hi Vinay, Thank you for the patch. On Wed, Aug 12, 2020 at 12:55:50PM +0530, Vinay Simha BN wrote: > - bus formats read from drm_bridge_state.output_bus_cfg.format > and .atomic_get_input_bus_fmts() instead of connector > > Signed-off-by: Vinay Simha BN > > --- > v1: > * Laurent Pinchart

[PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Vinay Simha BN
- bus formats read from drm_bridge_state.output_bus_cfg.format and .atomic_get_input_bus_fmts() instead of connector Signed-off-by: Vinay Simha BN --- v1: * Laurent Pinchart review comments incorporated drm_bridge_state.output_bus_cfg.format instead of connector ---