Re: [PATCH] drm/bridge: lvds-encoder: remove surplus NULL checks

2019-01-22 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Fri, Jan 18, 2019 at 11:11:38PM +, Peter Rosin wrote: > The gpio API explicitly allows skipping the NULL check, precisely to > allow for neat support for optional gpios. Which is exactly what is at > play here. > > Reported-by: Andrzej Hajda > Signed-of

Re: [PATCH] drm/bridge: lvds-encoder: remove surplus NULL checks

2019-01-21 Thread Daniel Vetter
On Fri, Jan 18, 2019 at 11:11:38PM +, Peter Rosin wrote: > The gpio API explicitly allows skipping the NULL check, precisely to > allow for neat support for optional gpios. Which is exactly what is at > play here. > > Reported-by: Andrzej Hajda > Signed-off-by: Peter Rosin lgtm, Reviewed-by

[PATCH] drm/bridge: lvds-encoder: remove surplus NULL checks

2019-01-18 Thread Peter Rosin
The gpio API explicitly allows skipping the NULL check, precisely to allow for neat support for optional gpios. Which is exactly what is at play here. Reported-by: Andrzej Hajda Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/lvds-encoder.c | 6 ++ 1 file changed, 2 insertions(+), 4 d