Re: [PATCH] drm/i915: Consistently use enum pipe for PCH transcoders

2017-07-17 Thread Matthias Kaehlcke
El Mon, Jul 17, 2017 at 11:07:01AM +0200 Daniel Vetter ha dit: > On Fri, Jul 14, 2017 at 06:04:03PM -0700, Matthias Kaehlcke wrote: > > The current code uses two different enum types for PCH transcoders and > > performs implicit conversions between the two types. This is error prone > > and causes

Re: [PATCH] drm/i915: Consistently use enum pipe for PCH transcoders

2017-07-17 Thread Daniel Vetter
On Fri, Jul 14, 2017 at 06:04:03PM -0700, Matthias Kaehlcke wrote: > The current code uses two different enum types for PCH transcoders and > performs implicit conversions between the two types. This is error prone > and causes clang to raise warnings like this: > > drivers/gpu/drm/i915/intel_dp.c

[PATCH] drm/i915: Consistently use enum pipe for PCH transcoders

2017-07-14 Thread Matthias Kaehlcke
The current code uses two different enum types for PCH transcoders and performs implicit conversions between the two types. This is error prone and causes clang to raise warnings like this: drivers/gpu/drm/i915/intel_dp.c:3546:51: warning: implicit conversion from enumeration type 'enum pipe' to