Re: [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-14 Thread Jisheng Zhang
Hi Ville, On Tue, 13 Apr 2021 19:59:34 +0300 Ville Syrjälä wrote: > > > On Tue, Apr 13, 2021 at 05:02:40PM +0800, Jisheng Zhang wrote: > > I met below error during boot with i915 builtin if pass > > "i915.mitigations=off": > > [0.015589] Booting kernel: `off' invalid for parameter > >

Re: [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-14 Thread Jisheng Zhang
On Tue, 13 Apr 2021 19:59:34 +0300 Ville Syrjälä wrote: > > On Tue, Apr 13, 2021 at 05:02:40PM +0800, Jisheng Zhang wrote: > > I met below error during boot with i915 builtin if pass > > "i915.mitigations=off": > > [0.015589] Booting kernel: `off' invalid for parameter > >

Re: [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Ville Syrjälä
On Tue, Apr 13, 2021 at 05:02:40PM +0800, Jisheng Zhang wrote: > I met below error during boot with i915 builtin if pass > "i915.mitigations=off": > [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' > > The reason is slab subsystem isn't ready at that time, so

[PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Jisheng Zhang
I met below error during boot with i915 builtin if pass "i915.mitigations=off": [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' The reason is slab subsystem isn't ready at that time, so kstrdup() returns NULL. Fix this issue by using stack var instead of kstrdup().