Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-07 Thread Qiang Yu
Applied to drm-misc-next. Regards, Qiang On Thu, Feb 4, 2021 at 10:24 PM Lukasz Luba wrote: > > > > On 2/4/21 1:39 PM, Robin Murphy wrote: > > On 2021-02-03 02:01, Qiang Yu wrote: > >> On Tue, Feb 2, 2021 at 10:02 PM Lukasz Luba wrote: > >>> > >>> > >>> > >>> On 2/2/21 1:01 AM, Qiang Yu wrote:

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-04 Thread Lukasz Luba
On 2/4/21 1:39 PM, Robin Murphy wrote: On 2021-02-03 02:01, Qiang Yu wrote: On Tue, Feb 2, 2021 at 10:02 PM Lukasz Luba wrote: On 2/2/21 1:01 AM, Qiang Yu wrote: Hi Lukasz, Thanks for the explanation. So the deferred timer option makes a mistake that when GPU goes from idle to busy f

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-04 Thread Robin Murphy
On 2021-02-03 02:01, Qiang Yu wrote: On Tue, Feb 2, 2021 at 10:02 PM Lukasz Luba wrote: On 2/2/21 1:01 AM, Qiang Yu wrote: Hi Lukasz, Thanks for the explanation. So the deferred timer option makes a mistake that when GPU goes from idle to busy for only one poll periodic, in this case 50ms,

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-02 Thread Qiang Yu
On Tue, Feb 2, 2021 at 10:02 PM Lukasz Luba wrote: > > > > On 2/2/21 1:01 AM, Qiang Yu wrote: > > Hi Lukasz, > > > > Thanks for the explanation. So the deferred timer option makes a mistake > > that > > when GPU goes from idle to busy for only one poll periodic, in this > > case 50ms, right? > >

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-02 Thread Lukasz Luba
On 2/2/21 1:01 AM, Qiang Yu wrote: Hi Lukasz, Thanks for the explanation. So the deferred timer option makes a mistake that when GPU goes from idle to busy for only one poll periodic, in this case 50ms, right? Not exactly. Driver sets the polling interval to 50ms (in this case) because it n

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-01 Thread Qiang Yu
Hi Lukasz, Thanks for the explanation. So the deferred timer option makes a mistake that when GPU goes from idle to busy for only one poll periodic, in this case 50ms, right? But delayed timer will wakeup CPU every 50ms even when system is idle, will this cause more power consumption for the case

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-02-01 Thread Lukasz Luba
Hi Qiang, On 1/30/21 1:51 PM, Qiang Yu wrote: Thanks for the patch. But I can't observe any difference on glmark2 with or without this patch. Maybe you can provide other test which can benefit from it. This is a design problem and has impact on the whole system. There is a few issues. When the

Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-01-30 Thread Qiang Yu
Thanks for the patch. But I can't observe any difference on glmark2 with or without this patch. Maybe you can provide other test which can benefit from it. Considering it will wake up CPU more frequently, and user may choose to change this by sysfs, I'd like to not apply it. Regards, Qiang On We

[PATCH] drm/lima: Use delayed timer as default in devfreq profile

2021-01-27 Thread Lukasz Luba
Devfreq framework supports 2 modes for monitoring devices. Use delayed timer as default instead of deferrable timer in order to monitor the GPU status regardless of CPU idle. Signed-off-by: Lukasz Luba --- Hi all, I've missed the Lima driver while working on Panfrost patch for fixing the issue w