Re: [Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

2017-12-06 Thread Karol Herbst
Reviewed-by: Karol Herbst On Thu, Nov 30, 2017 at 8:53 PM, Christoph Böhmwalder wrote: > The kbuild test bot complained about a new coccinelle warning nearby, > which sparked a discussion about the assignment to 'memory' inside of > the conditional expression. See Link below for the original po

[PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

2017-11-30 Thread Christoph Böhmwalder
The kbuild test bot complained about a new coccinelle warning nearby, which sparked a discussion about the assignment to 'memory' inside of the conditional expression. See Link below for the original post. Fix the assignment to silence the coccinelle warning and also make the code look a little n

Re: [Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings (fwd)

2017-11-28 Thread Julia Lawall
expression. > > > > julia > > > > -- Forwarded message -- > > Date: Tue, 28 Nov 2017 13:23:36 +0800 > > From: kbuild test robot > > To: kbu...@01.org > > Cc: Julia Lawall > > Subject: [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci

Re: [Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings (fwd)

2017-11-28 Thread Karol Herbst
is is a false positive, but I wonder if it is really necessary to put > the assignment in the conditional test expression. > > julia > > -- Forwarded message -- > Date: Tue, 28 Nov 2017 13:23:36 +0800 > From: kbuild test robot > To: kbu...@01.org > Cc: Julia La

[PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings (fwd)

2017-11-28 Thread Julia Lawall
/mmu: fix odd_ptr_err.cocci warnings CC: kbuild-...@01.org CC: linux-kernel@vger.kernel.org TO: Ben Skeggs CC: David Airlie CC: dri-de...@lists.freedesktop.org CC: nouv...@lists.freedesktop.org CC: linux-kernel@vger.kernel.org drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c:109:5-11: inconsistent