Re: [PATCH] drm/nouveau: fix relocations applying logic and a double-free

2020-11-25 Thread Daniel Vetter
On Mon, Nov 23, 2020 at 10:51:25AM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2020 at 4:23 PM Matti Hamalainen wrote: > > > > Commit 03e0d26fcf79 ("drm/nouveau: slowpath for pushbuf ioctl") included > > a logic-bug which results in the relocations not actually getting > > applied at all as the

Re: [PATCH] drm/nouveau: fix relocations applying logic and a double-free

2020-11-23 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 4:23 PM Matti Hamalainen wrote: > > Commit 03e0d26fcf79 ("drm/nouveau: slowpath for pushbuf ioctl") included > a logic-bug which results in the relocations not actually getting > applied at all as the call to nouveau_gem_pushbuf_reloc_apply() is > never reached. This causes

[PATCH] drm/nouveau: fix relocations applying logic and a double-free

2020-11-20 Thread Matti Hamalainen
Commit 03e0d26fcf79 ("drm/nouveau: slowpath for pushbuf ioctl") included a logic-bug which results in the relocations not actually getting applied at all as the call to nouveau_gem_pushbuf_reloc_apply() is never reached. This causes a regression with graphical corruption, triggered when relocations