Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-04-07 Thread Christian König
Christian's comment if you guys agree. Somebody else already provided a patch which I reviewed, but I'm not sure if that landed either. Also, the patch here is for radeon but the pagefault issue reported by Felix is affected by the amdgpu one: radeon patch: drm/radeon/t

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-04-07 Thread Daniel Gomez
n't set the tt object to bound if it > > doesn't have a GTT address. > > > > Going to provide a patch for this. > > Did this patch ever land? I don't think so but I might send a v2 following Christian's comment if you guys agree. Also, the patch here is

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-04-06 Thread Alex Deucher
trying to clear > > the userptr memory? > > > > Something like: > > > > amdgpu_ttm_backend_bind: > > if (gtt->userptr) { > > r = amdgpu_ttm_tt_pin_userptr(bdev, ttm); > > if (r) ... > > gtt->sg_table = true; &g

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-22 Thread Daniel Gomez
gtt->sg_table = true; > > } > > > > amdgpu_ttm_backend_unbind: > > if (gtt->sg_table) { > > if (gtt->user_ptr) ... > > } > > > > If you agree, I'll send a v2 patch. Otherwise, maybe we could return > > within a

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-22 Thread Christian König
op.org ; linux-kernel@vger.kernel.org Betreff: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages If userptr pages have been pinned but not bounded, they remain uncleared. Signed-off-by: Daniel Gomez --- drivers/gpu/drm/radeon/radeon_ttm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 de

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-22 Thread Daniel Gomez
t; Regards, >Felix > > On 2021-03-18 10:57 p.m., Alex Deucher wrote: > > Applied. Thanks! > > > > Alex > > > > On Thu, Mar 18, 2021 at 5:00 AM Koenig, Christian > > wrote: > >> Reviewed-by: Christian König > >> ____________

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-19 Thread Felix Kuehling
CH] drm/radeon/ttm: Fix memory leak userptr pages If userptr pages have been pinned but not bounded, they remain uncleared. Signed-off-by: Daniel Gomez --- drivers/gpu/drm/radeon/radeon_ttm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeo

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-18 Thread Alex Deucher
r ; Koenig, Christian > ; David Airlie ; Daniel Vetter > ; amd-...@lists.freedesktop.org > ; dri-de...@lists.freedesktop.org > ; linux-kernel@vger.kernel.org > > Betreff: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages > > If userptr pages have been pinned but not

[PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-03-18 Thread Daniel Gomez
If userptr pages have been pinned but not bounded, they remain uncleared. Signed-off-by: Daniel Gomez --- drivers/gpu/drm/radeon/radeon_ttm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index