Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-12 Thread Tejun Heo
Hello, On Fri, Jul 08, 2016 at 02:52:30PM +0900, Michel Dänzer wrote: > On 07.07.2016 16:43, Christian König wrote: > >>> Also, what kind of delays matter here? Is it millisec range or micro? > >> It can be the latter in theory, but normally rather the former. > > > > Well to be precise with a

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-12 Thread Tejun Heo
Hello, On Fri, Jul 08, 2016 at 02:52:30PM +0900, Michel Dänzer wrote: > On 07.07.2016 16:43, Christian König wrote: > >>> Also, what kind of delays matter here? Is it millisec range or micro? > >> It can be the latter in theory, but normally rather the former. > > > > Well to be precise with a

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-07 Thread Michel Dänzer
On 07.07.2016 16:43, Christian König wrote: > Am 07.07.2016 um 05:32 schrieb Michel Dänzer: >> On 06.07.2016 22:45, Tejun Heo wrote: >>> On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: >>> Not being very familiar with the workqueue APIs, I'll describe how it's supposed to

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-07 Thread Michel Dänzer
On 07.07.2016 16:43, Christian König wrote: > Am 07.07.2016 um 05:32 schrieb Michel Dänzer: >> On 06.07.2016 22:45, Tejun Heo wrote: >>> On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: >>> Not being very familiar with the workqueue APIs, I'll describe how it's supposed to

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-07 Thread Christian König
Am 07.07.2016 um 05:32 schrieb Michel Dänzer: On 06.07.2016 22:45, Tejun Heo wrote: On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: Not being very familiar with the workqueue APIs, I'll describe how it's supposed to work from a driver POV, which will hopefully help you guys

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-07 Thread Christian König
Am 07.07.2016 um 05:32 schrieb Michel Dänzer: On 06.07.2016 22:45, Tejun Heo wrote: On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: Not being very familiar with the workqueue APIs, I'll describe how it's supposed to work from a driver POV, which will hopefully help you guys

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-06 Thread Michel Dänzer
On 06.07.2016 22:45, Tejun Heo wrote: > On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: > >> Not being very familiar with the workqueue APIs, I'll describe how it's >> supposed to work from a driver POV, which will hopefully help you guys >> decide on the most appropriate

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-06 Thread Michel Dänzer
On 06.07.2016 22:45, Tejun Heo wrote: > On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: > >> Not being very familiar with the workqueue APIs, I'll describe how it's >> supposed to work from a driver POV, which will hopefully help you guys >> decide on the most appropriate

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-06 Thread Tejun Heo
Hello, Michel. On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: > There is an ordering requirement between the two queues, but it's > enforced by the driver (by only queuing the unpin work once a flip has > completed, which only happens after the corresponding flip work has run).

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-06 Thread Tejun Heo
Hello, Michel. On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: > There is an ordering requirement between the two queues, but it's > enforced by the driver (by only queuing the unpin work once a flip has > completed, which only happens after the corresponding flip work has run).

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-05 Thread Michel Dänzer
On 06.07.2016 06:06, Tejun Heo wrote: > On Mon, Jul 04, 2016 at 12:58:32PM +0900, Michel Dänzer wrote: >> On 02.07.2016 22:46, Tejun Heo wrote: >>> On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: alloc_workqueue replaces deprecated create_singlethread_workqueue().

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-05 Thread Michel Dänzer
On 06.07.2016 06:06, Tejun Heo wrote: > On Mon, Jul 04, 2016 at 12:58:32PM +0900, Michel Dänzer wrote: >> On 02.07.2016 22:46, Tejun Heo wrote: >>> On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: alloc_workqueue replaces deprecated create_singlethread_workqueue().

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-05 Thread Tejun Heo
Hello, On Mon, Jul 04, 2016 at 12:58:32PM +0900, Michel Dänzer wrote: > On 02.07.2016 22:46, Tejun Heo wrote: > > On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: > >> alloc_workqueue replaces deprecated create_singlethread_workqueue(). > >> > >> A dedicated workqueue has

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-05 Thread Tejun Heo
Hello, On Mon, Jul 04, 2016 at 12:58:32PM +0900, Michel Dänzer wrote: > On 02.07.2016 22:46, Tejun Heo wrote: > > On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: > >> alloc_workqueue replaces deprecated create_singlethread_workqueue(). > >> > >> A dedicated workqueue has

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-03 Thread Michel Dänzer
On 02.07.2016 22:46, Tejun Heo wrote: > On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: >> alloc_workqueue replaces deprecated create_singlethread_workqueue(). >> >> A dedicated workqueue has been used since work items need to be flushed >> as a group rather than

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-03 Thread Michel Dänzer
On 02.07.2016 22:46, Tejun Heo wrote: > On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: >> alloc_workqueue replaces deprecated create_singlethread_workqueue(). >> >> A dedicated workqueue has been used since work items need to be flushed >> as a group rather than

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-02 Thread Tejun Heo
On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since work items need to be flushed > as a group rather than individually. > > Since the flip_queue workqueue is

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-02 Thread Tejun Heo
On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since work items need to be flushed > as a group rather than individually. > > Since the flip_queue workqueue is

[PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-02 Thread Bhaktipriya Shridhar
alloc_workqueue replaces deprecated create_singlethread_workqueue(). A dedicated workqueue has been used since work items need to be flushed as a group rather than individually. Since the flip_queue workqueue is involved in page-flipping and is not being used on a memory reclaim path,

[PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-02 Thread Bhaktipriya Shridhar
alloc_workqueue replaces deprecated create_singlethread_workqueue(). A dedicated workqueue has been used since work items need to be flushed as a group rather than individually. Since the flip_queue workqueue is involved in page-flipping and is not being used on a memory reclaim path,

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-06-28 Thread Bhaktipriya Shridhar
Please ignore this mail. Thanks, Bhaktipriya On Tue, Jun 28, 2016 at 10:56 PM, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since work items need to be flushed > as a group

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-06-28 Thread Bhaktipriya Shridhar
Please ignore this mail. Thanks, Bhaktipriya On Tue, Jun 28, 2016 at 10:56 PM, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since work items need to be flushed > as a group rather than individually. >

[PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-06-28 Thread Bhaktipriya Shridhar
alloc_workqueue replaces deprecated create_singlethread_workqueue(). A dedicated workqueue has been used since work items need to be flushed as a group rather than individually. Since the flip_queue workqueue is involved in page-flipping and is not being used on a memory reclaim path,

[PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-06-28 Thread Bhaktipriya Shridhar
alloc_workqueue replaces deprecated create_singlethread_workqueue(). A dedicated workqueue has been used since work items need to be flushed as a group rather than individually. Since the flip_queue workqueue is involved in page-flipping and is not being used on a memory reclaim path,