Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

2017-07-10 Thread Mark yao
On 2017年07月11日 03:04, Sean Paul wrote: On Fri, Jul 07, 2017 at 08:56:28AM +0800, Mark yao wrote: On 2017年07月07日 05:58, Gustavo A. R. Silva wrote: The right variable to check here is port, not dp. This issue was detected using Coccinelle and the following semantic patch: @@ expression x; ident

Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

2017-07-10 Thread Sean Paul
On Fri, Jul 07, 2017 at 08:56:28AM +0800, Mark yao wrote: > On 2017年07月07日 05:58, Gustavo A. R. Silva wrote: > > The right variable to check here is port, not dp. > > > > This issue was detected using Coccinelle and the following semantic patch: > > > > @@ > > expression x; > > identifier fld; >

Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

2017-07-06 Thread Mark yao
On 2017年07月07日 05:58, Gustavo A. R. Silva wrote: The right variable to check here is port, not dp. This issue was detected using Coccinelle and the following semantic patch: @@ expression x; identifier fld; @@ * x = devm_kzalloc(...); ... when != x == NULL x->fld Signed-off-by: Gustavo

[PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

2017-07-06 Thread Gustavo A. R. Silva
The right variable to check here is port, not dp. This issue was detected using Coccinelle and the following semantic patch: @@ expression x; identifier fld; @@ * x = devm_kzalloc(...); ... when != x == NULL x->fld Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/rockchip/cdn-dp-cor