Re: [PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Mark yao
On 2015年11月10日 22:57, Heiko Stuebner wrote: Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: From: Dominik Behr VOP_WINx_DSP_ST does not require subtracting 1 from the values written to it. It actually causes the screen to be shifted by one pixel. Signed-off-by: Mark Yao One

Re: [PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Heiko Stuebner
Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao One thing I noticed, the original patch [0]

Re: [PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Heiko Stuebner
Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao funny I never noticed that shift, but now

Re: [PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Yakir Yang
Hi Mark, On 11/10/2015 05:59 PM, Mark Yao wrote: From: Dominik Behr VOP_WINx_DSP_ST does not require subtracting 1 from the values written to it. It actually causes the screen to be shifted by one pixel. Signed-off-by: Mark Yao I have meet the screen shift problem on RK3036 SDK board, and

[PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Mark Yao
From: Dominik Behr VOP_WINx_DSP_ST does not require subtracting 1 from the values written to it. It actually causes the screen to be shifted by one pixel. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Heiko Stuebner
Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao

[PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Mark Yao
From: Dominik Behr VOP_WINx_DSP_ST does not require subtracting 1 from the values written to it. It actually causes the screen to be shifted by one pixel. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c |4 ++-- 1 file

Re: [PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Yakir Yang
Hi Mark, On 11/10/2015 05:59 PM, Mark Yao wrote: From: Dominik Behr VOP_WINx_DSP_ST does not require subtracting 1 from the values written to it. It actually causes the screen to be shifted by one pixel. Signed-off-by: Mark Yao I have meet the

Re: [PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Mark yao
On 2015年11月10日 22:57, Heiko Stuebner wrote: Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: From: Dominik Behr VOP_WINx_DSP_ST does not require subtracting 1 from the values written to it. It actually causes the screen to be shifted by one pixel. Signed-off-by:

Re: [PATCH] drm/rockchip: vop: fix window origin calculation

2015-11-10 Thread Heiko Stuebner
Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao