Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-29 Thread Sean Paul
On Thu, Sep 29, 2016 at 8:04 AM, Maxime Ripard wrote: > Hi, > > On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: >> As an aside, it seems like (from the diff, I haven't looked at the >> code) the bridge_pre_enable and bridge_post_disable calls are

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-29 Thread Sean Paul
On Thu, Sep 29, 2016 at 8:04 AM, Maxime Ripard wrote: > Hi, > > On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: >> As an aside, it seems like (from the diff, I haven't looked at the >> code) the bridge_pre_enable and bridge_post_disable calls are missing, >> and the enable/disable

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-29 Thread Maxime Ripard
Hi, On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: > As an aside, it seems like (from the diff, I haven't looked at the > code) the bridge_pre_enable and bridge_post_disable calls are missing, > and the enable/disable calls are in the wrong place. Actually, I don't even think that's

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-29 Thread Maxime Ripard
Hi, On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: > As an aside, it seems like (from the diff, I haven't looked at the > code) the bridge_pre_enable and bridge_post_disable calls are missing, > and the enable/disable calls are in the wrong place. Actually, I don't even think that's

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-28 Thread Maxime Ripard
Hi Sean, On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: > As an aside, it seems like (from the diff, I haven't looked at the > code) the bridge_pre_enable and bridge_post_disable calls are missing, > and the enable/disable calls are in the wrong place. You're right. I have to push

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-28 Thread Maxime Ripard
Hi Sean, On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: > As an aside, it seems like (from the diff, I haven't looked at the > code) the bridge_pre_enable and bridge_post_disable calls are missing, > and the enable/disable calls are in the wrong place. You're right. I have to push

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-27 Thread Sean Paul
On Sat, Sep 24, 2016 at 4:18 PM, Maxime Ripard wrote: > On Fri, Sep 23, 2016 at 11:43:55PM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On 23 September 2016 at 23:16, Maxime Ripard >> wrote: >> > On Thu, Sep 22, 2016 at

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-27 Thread Sean Paul
On Sat, Sep 24, 2016 at 4:18 PM, Maxime Ripard wrote: > On Fri, Sep 23, 2016 at 11:43:55PM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On 23 September 2016 at 23:16, Maxime Ripard >> wrote: >> > On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: >> >> Hi Maxime, >> >> >> >> On

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-26 Thread Maxime Ripard
On Fri, Sep 23, 2016 at 11:43:55PM +1000, Jonathan Liu wrote: > Hi Maxime, > > On 23 September 2016 at 23:16, Maxime Ripard > wrote: > > On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: > >> Hi Maxime, > >> > >> On Thursday, 22 September 2016,

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-26 Thread Maxime Ripard
On Fri, Sep 23, 2016 at 11:43:55PM +1000, Jonathan Liu wrote: > Hi Maxime, > > On 23 September 2016 at 23:16, Maxime Ripard > wrote: > > On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: > >> Hi Maxime, > >> > >> On Thursday, 22 September 2016, Maxime Ripard > >> >> com> wrote: >

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-23 Thread Jonathan Liu
Hi Maxime, On 23 September 2016 at 23:16, Maxime Ripard wrote: > On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On Thursday, 22 September 2016, Maxime Ripard > com> wrote: >> >> > On Wed, Sep 21,

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-23 Thread Jonathan Liu
Hi Maxime, On 23 September 2016 at 23:16, Maxime Ripard wrote: > On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On Thursday, 22 September 2016, Maxime Ripard > com> wrote: >> >> > On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: >> > > The panel

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-23 Thread Maxime Ripard
On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: > Hi Maxime, > > On Thursday, 22 September 2016, Maxime Ripard com> wrote: > > > On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: > > > The panel should be enabled after the controller so

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-23 Thread Maxime Ripard
On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: > Hi Maxime, > > On Thursday, 22 September 2016, Maxime Ripard com> wrote: > > > On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: > > > The panel should be enabled after the controller so that the panel > > >

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-21 Thread Jonathan Liu
Hi Maxime, On 22 September 2016 at 07:03, Maxime Ripard wrote: > On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: >> The panel should be enabled after the controller so that the panel >> prepare/enable delays are properly taken into account.

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-21 Thread Jonathan Liu
Hi Maxime, On 22 September 2016 at 07:03, Maxime Ripard wrote: > On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: >> The panel should be enabled after the controller so that the panel >> prepare/enable delays are properly taken into account. Similarly, the >> panel should be

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-21 Thread Maxime Ripard
Hi, On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: > The panel should be enabled after the controller so that the panel > prepare/enable delays are properly taken into account. Similarly, the > panel should be disabled before the controller so that the panel > unprepare/disable

Re: [PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-21 Thread Maxime Ripard
Hi, On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: > The panel should be enabled after the controller so that the panel > prepare/enable delays are properly taken into account. Similarly, the > panel should be disabled before the controller so that the panel > unprepare/disable

[PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-21 Thread Jonathan Liu
The panel should be enabled after the controller so that the panel prepare/enable delays are properly taken into account. Similarly, the panel should be disabled before the controller so that the panel unprepare/disable delays are properly taken into account. This is useful for avoiding visual

[PATCH] drm/sun4i: rgb: Enable panel after controller

2016-09-21 Thread Jonathan Liu
The panel should be enabled after the controller so that the panel prepare/enable delays are properly taken into account. Similarly, the panel should be disabled before the controller so that the panel unprepare/disable delays are properly taken into account. This is useful for avoiding visual