Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Alex Deucher
On Fri, Jan 27, 2017 at 3:22 AM, Christian König wrote: > Am 27.01.2017 um 08:30 schrieb Daniel Vetter: >> >> On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: >>> >>> On 01/27/2017 03:29 AM, Michel Dänzer wrote: On 26/01/17 09:46 AM, Sinclair

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Alex Deucher
On Fri, Jan 27, 2017 at 3:22 AM, Christian König wrote: > Am 27.01.2017 um 08:30 schrieb Daniel Vetter: >> >> On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: >>> >>> On 01/27/2017 03:29 AM, Michel Dänzer wrote: On 26/01/17 09:46 AM, Sinclair Yeh wrote: > > On

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 03:43:18PM +0100, Christian König wrote: > Am 27.01.2017 um 15:12 schrieb Daniel Vetter: > > On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: > > > Am 27.01.2017 um 08:30 schrieb Daniel Vetter: > > > > On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 03:43:18PM +0100, Christian König wrote: > Am 27.01.2017 um 15:12 schrieb Daniel Vetter: > > On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: > > > Am 27.01.2017 um 08:30 schrieb Daniel Vetter: > > > > On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Christian König
Am 27.01.2017 um 15:12 schrieb Daniel Vetter: On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: Am 27.01.2017 um 08:30 schrieb Daniel Vetter: On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: On 01/27/2017 03:29 AM, Michel Dänzer wrote: On 26/01/17 09:46 AM,

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Christian König
Am 27.01.2017 um 15:12 schrieb Daniel Vetter: On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: Am 27.01.2017 um 08:30 schrieb Daniel Vetter: On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: On 01/27/2017 03:29 AM, Michel Dänzer wrote: On 26/01/17 09:46 AM,

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: > Am 27.01.2017 um 08:30 schrieb Daniel Vetter: > > On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: > > > On 01/27/2017 03:29 AM, Michel Dänzer wrote: > > > > On 26/01/17 09:46 AM, Sinclair Yeh wrote: > > > > > On

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 09:22:47AM +0100, Christian König wrote: > Am 27.01.2017 um 08:30 schrieb Daniel Vetter: > > On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: > > > On 01/27/2017 03:29 AM, Michel Dänzer wrote: > > > > On 26/01/17 09:46 AM, Sinclair Yeh wrote: > > > > > On

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Christian König
Am 27.01.2017 um 08:30 schrieb Daniel Vetter: On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: On 01/27/2017 03:29 AM, Michel Dänzer wrote: On 26/01/17 09:46 AM, Sinclair Yeh wrote: On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: Am 25.01.2017 um 10:25

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-27 Thread Christian König
Am 27.01.2017 um 08:30 schrieb Daniel Vetter: On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: On 01/27/2017 03:29 AM, Michel Dänzer wrote: On 26/01/17 09:46 AM, Sinclair Yeh wrote: On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: Am 25.01.2017 um 10:25

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-26 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: > On 01/27/2017 03:29 AM, Michel Dänzer wrote: > > On 26/01/17 09:46 AM, Sinclair Yeh wrote: > >> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: > >>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: > On

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-26 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 07:23:58AM +0100, Thomas Hellstrom wrote: > On 01/27/2017 03:29 AM, Michel Dänzer wrote: > > On 26/01/17 09:46 AM, Sinclair Yeh wrote: > >> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: > >>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: > On

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-26 Thread Thomas Hellstrom
On 01/27/2017 03:29 AM, Michel Dänzer wrote: > On 26/01/17 09:46 AM, Sinclair Yeh wrote: >> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: >>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: On 01/25/2017 09:21 AM, Michel Dänzer wrote: > From: Michel Dänzer

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-26 Thread Thomas Hellstrom
On 01/27/2017 03:29 AM, Michel Dänzer wrote: > On 26/01/17 09:46 AM, Sinclair Yeh wrote: >> On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: >>> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: On 01/25/2017 09:21 AM, Michel Dänzer wrote: > From: Michel Dänzer > >

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-26 Thread Michel Dänzer
On 26/01/17 09:46 AM, Sinclair Yeh wrote: > On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: >> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: >>> On 01/25/2017 09:21 AM, Michel Dänzer wrote: From: Michel Dänzer The current caching state

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-26 Thread Michel Dänzer
On 26/01/17 09:46 AM, Sinclair Yeh wrote: > On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: >> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: >>> On 01/25/2017 09:21 AM, Michel Dänzer wrote: From: Michel Dänzer The current caching state may not be tt_cached, even

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Sinclair Yeh
On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: > Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: > >On 01/25/2017 09:21 AM, Michel Dänzer wrote: > >>From: Michel Dänzer > >> > >>The current caching state may not be tt_cached, even though the >

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Sinclair Yeh
On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: > Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: > >On 01/25/2017 09:21 AM, Michel Dänzer wrote: > >>From: Michel Dänzer > >> > >>The current caching state may not be tt_cached, even though the > >>placement contains

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Christian König
Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: On 01/25/2017 09:21 AM, Michel Dänzer wrote: From: Michel Dänzer The current caching state may not be tt_cached, even though the placement contains TTM_PL_FLAG_CACHED, because placement can contain multiple caching

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Christian König
Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: On 01/25/2017 09:21 AM, Michel Dänzer wrote: From: Michel Dänzer The current caching state may not be tt_cached, even though the placement contains TTM_PL_FLAG_CACHED, because placement can contain multiple caching flags. Trying to swap out

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Thomas Hellstrom
On 01/25/2017 09:21 AM, Michel Dänzer wrote: > From: Michel Dänzer > > The current caching state may not be tt_cached, even though the > placement contains TTM_PL_FLAG_CACHED, because placement can contain > multiple caching flags. Trying to swap out such a BO would trip

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Thomas Hellstrom
On 01/25/2017 09:21 AM, Michel Dänzer wrote: > From: Michel Dänzer > > The current caching state may not be tt_cached, even though the > placement contains TTM_PL_FLAG_CACHED, because placement can contain > multiple caching flags. Trying to swap out such a BO would trip up the > >

[PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Michel Dänzer
From: Michel Dänzer The current caching state may not be tt_cached, even though the placement contains TTM_PL_FLAG_CACHED, because placement can contain multiple caching flags. Trying to swap out such a BO would trip up the BUG_ON(ttm->caching_state !=

[PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Michel Dänzer
From: Michel Dänzer The current caching state may not be tt_cached, even though the placement contains TTM_PL_FLAG_CACHED, because placement can contain multiple caching flags. Trying to swap out such a BO would trip up the BUG_ON(ttm->caching_state != tt_cached); in ttm_tt_swapout.