Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

2017-04-17 Thread Eric Anholt
Sean Paul writes: > On Mon, Apr 17, 2017 at 09:26:03AM -0700, Eric Anholt wrote: >> We were returning without decrementing if the error happened, meaning >> that at the next submit we wouldn't try to bring up the power domain. >> >> Signed-off-by: Eric Anholt

Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

2017-04-17 Thread Eric Anholt
Sean Paul writes: > On Mon, Apr 17, 2017 at 09:26:03AM -0700, Eric Anholt wrote: >> We were returning without decrementing if the error happened, meaning >> that at the next submit we wouldn't try to bring up the power domain. >> >> Signed-off-by: Eric Anholt > > This change looks good to me.

Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

2017-04-17 Thread Sean Paul
On Mon, Apr 17, 2017 at 09:26:03AM -0700, Eric Anholt wrote: > We were returning without decrementing if the error happened, meaning > that at the next submit we wouldn't try to bring up the power domain. > > Signed-off-by: Eric Anholt This change looks good to me. It seems a

Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

2017-04-17 Thread Sean Paul
On Mon, Apr 17, 2017 at 09:26:03AM -0700, Eric Anholt wrote: > We were returning without decrementing if the error happened, meaning > that at the next submit we wouldn't try to bring up the power domain. > > Signed-off-by: Eric Anholt This change looks good to me. It seems a little odd to wrap

[PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

2017-04-17 Thread Eric Anholt
We were returning without decrementing if the error happened, meaning that at the next submit we wouldn't try to bring up the power domain. Signed-off-by: Eric Anholt --- I stumbled across this error when testing my CMA patch with a very low (64MB) CMA area -- we would oops on

[PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

2017-04-17 Thread Eric Anholt
We were returning without decrementing if the error happened, meaning that at the next submit we wouldn't try to bring up the power domain. Signed-off-by: Eric Anholt --- I stumbled across this error when testing my CMA patch with a very low (64MB) CMA area -- we would oops on the submit after