Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-06-02 Thread Emil Velikov
On Mon, 1 Jun 2020 at 01:25, Rodrigo Siqueira wrote: > > Hi, > > First of all, thanks a lot for all your patch. And thanks Emil for your > feedback. > > I have a suggestion here: > > Emil: > Could you give me your Acked-by or maybe Reviewed-by for the writeback > series? With that, I can finally

Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-05-31 Thread Rodrigo Siqueira
Hi, First of all, thanks a lot for all your patch. And thanks Emil for your feedback. I have a suggestion here: Emil: Could you give me your Acked-by or maybe Reviewed-by for the writeback series? With that, I can finally apply the series. Sidong: Secondly, after applying the writeback series,

Re: [PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-05-31 Thread Emil Velikov
On Sun, 31 May 2020 at 14:12, Sidong Yang wrote: > > Optimize looping pixels in compute_crc() and blend(). Calculate > src_offset in start of looping horizontally and increase it. > It's better than calculating in every pixels. > When you say "optimize" have you observed any actual benefits of

[PATCH] drm/vkms: Optimize compute_crc(), blend()

2020-05-31 Thread Sidong Yang
Optimize looping pixels in compute_crc() and blend(). Calculate src_offset in start of looping horizontally and increase it. It's better than calculating in every pixels. Cc: Rodrigo Siqueira Cc: David Airlie Cc: dri-de...@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Signed-off-by: