Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-08-01 Thread Sidong Yang
On Fri, Jul 31, 2020 at 08:33:25PM +0200, Daniel Vetter wrote: > On Fri, Jul 31, 2020 at 6:47 PM Melissa Wen wrote: > > > > On 07/31, Sidong Yang wrote: > > > On Fri, Jul 31, 2020 at 11:08:34AM +0200, dan...@ffwll.ch wrote: > > > > On Thu, Jul 30, 2020 at 07:09:25AM -0300, Melissa Wen wrote: > >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread Leandro Ribeiro
Hello everybody! I'm currently working on a writeback connector screenshooter for Weston. In order to test it, I'm using VKMS with Rodrigo's writeback connector patch: https://lkml.org/lkml/2020/5/11/449 Here is the link with the MR in Weston with more details of how I've tested it:

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread Daniel Vetter
On Fri, Jul 31, 2020 at 6:47 PM Melissa Wen wrote: > > On 07/31, Sidong Yang wrote: > > On Fri, Jul 31, 2020 at 11:08:34AM +0200, dan...@ffwll.ch wrote: > > > On Thu, Jul 30, 2020 at 07:09:25AM -0300, Melissa Wen wrote: > > > > On 07/29, Daniel Vetter wrote: > > > > > On Wed, Jul 29, 2020 at 9:09

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread Leandro Ribeiro
Hello everybody! I'm currently working on a writeback connector screenshooter for Weston. In order to test it, I'm using VKMS with Rodrigo's writeback connector patch: https://lkml.org/lkml/2020/5/11/449 Here is the link with the MR in Weston with more details of how I've tested it:

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread Leandro Ribeiro
Hello everybody! I'm currently working on a writeback connector screenshooter for Weston. In order to test it, I'm using VKMS with Rodrigo's writeback connector patch: https://lkml.org/lkml/2020/5/11/449 Here is the link with the MR in Weston with more details of how I've tested it:

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread Melissa Wen
On 07/31, Sidong Yang wrote: > On Fri, Jul 31, 2020 at 11:08:34AM +0200, dan...@ffwll.ch wrote: > > On Thu, Jul 30, 2020 at 07:09:25AM -0300, Melissa Wen wrote: > > > On 07/29, Daniel Vetter wrote: > > > > On Wed, Jul 29, 2020 at 9:09 PM Melissa Wen > > > > wrote: > > > > > > > > > > Melissa Wen

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread Sidong Yang
On Fri, Jul 31, 2020 at 11:08:34AM +0200, dan...@ffwll.ch wrote: > On Thu, Jul 30, 2020 at 07:09:25AM -0300, Melissa Wen wrote: > > On 07/29, Daniel Vetter wrote: > > > On Wed, Jul 29, 2020 at 9:09 PM Melissa Wen wrote: > > > > > > > > Melissa Wen > > > > > > > > On Sat, Jul 25, 2020 at 3:12 PM

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread daniel
On Thu, Jul 30, 2020 at 07:09:25AM -0300, Melissa Wen wrote: > On 07/29, Daniel Vetter wrote: > > On Wed, Jul 29, 2020 at 9:09 PM Melissa Wen wrote: > > > > > > Melissa Wen > > > > > > On Sat, Jul 25, 2020 at 3:12 PM Daniel Vetter wrote: > > > > > > > > On Sat, Jul 25, 2020 at 7:45 PM Melissa

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-30 Thread Melissa Wen
On 07/29, Daniel Vetter wrote: > On Wed, Jul 29, 2020 at 9:09 PM Melissa Wen wrote: > > > > Melissa Wen > > > > On Sat, Jul 25, 2020 at 3:12 PM Daniel Vetter wrote: > > > > > > On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote: > > > > > > > > On 07/25, Daniel Vetter wrote: > > > > > On Sat,

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-29 Thread Daniel Vetter
On Wed, Jul 29, 2020 at 9:09 PM Melissa Wen wrote: > > Melissa Wen > > On Sat, Jul 25, 2020 at 3:12 PM Daniel Vetter wrote: > > > > On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote: > > > > > > On 07/25, Daniel Vetter wrote: > > > > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > > > >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-29 Thread Melissa Wen
Melissa Wen On Sat, Jul 25, 2020 at 3:12 PM Daniel Vetter wrote: > > On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote: > > > > On 07/25, Daniel Vetter wrote: > > > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > > > > > > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote:

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-28 Thread daniel
On Tue, Jul 28, 2020 at 04:16:34PM +, Sidong Yang wrote: > On Sun, Jul 26, 2020 at 12:26:08PM +0200, Daniel Vetter wrote: > > On Sat, Jul 25, 2020 at 9:29 PM Melissa Wen wrote: > > > > > > On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen wrote: > > > > > > > > > No, this very first warning

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-28 Thread Sidong Yang
On Sun, Jul 26, 2020 at 12:26:08PM +0200, Daniel Vetter wrote: > On Sat, Jul 25, 2020 at 9:29 PM Melissa Wen wrote: > > > > On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen wrote: > > > > > > > No, this very first warning continues (only once) :( > > > > From here (drm_crtc_vblank_on): > > > >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-26 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 9:29 PM Melissa Wen wrote: > > On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen wrote: > > > > > No, this very first warning continues (only once) :( > > > From here (drm_crtc_vblank_on): > > > if (atomic_read(>refcount) != 0 || drm_vblank_offdelay == > > > 0) > > >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Melissa Wen
On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen wrote: > > > No, this very first warning continues (only once) :( > > From here (drm_crtc_vblank_on): > > if (atomic_read(>refcount) != 0 || drm_vblank_offdelay == 0) > > drm_WARN_ON(dev, drm_vblank_enable(dev, pipe)); > > Sorry,

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Melissa Wen
> No, this very first warning continues (only once) :( > From here (drm_crtc_vblank_on): > if (atomic_read(>refcount) != 0 || drm_vblank_offdelay == 0) > drm_WARN_ON(dev, drm_vblank_enable(dev, pipe)); Sorry, not sure when this warning is triggered. > > > But I'm still

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Melissa Wen
On 07/25, Daniel Vetter wrote: > On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote: > > > > On 07/25, Daniel Vetter wrote: > > > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > > > > > > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > > > > > On Wed, Jul 22, 2020 at

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote: > > On 07/25, Daniel Vetter wrote: > > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > > > > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > > > > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen > > > > wrote: > > > > > >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Melissa Wen
On 07/25, Daniel Vetter wrote: > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > > > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > > > > > > > On 07/22, dan...@ffwll.ch wrote: > > > > > On Wed, Jul 22, 2020 at

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > > > > > On 07/22, dan...@ffwll.ch wrote: > > > > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > > > >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-24 Thread Sidong Yang
On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > > > On 07/22, dan...@ffwll.ch wrote: > > > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > > > This patch adds a missing drm_crtc_vblank_put op to the pair > >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > On 07/22, dan...@ffwll.ch wrote: > > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > > This patch adds a missing drm_crtc_vblank_put op to the pair > > > drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks). >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-22 Thread Melissa Wen
On 07/22, dan...@ffwll.ch wrote: > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > This patch adds a missing drm_crtc_vblank_put op to the pair > > drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks). > > > > It clears the execution of the following

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-22 Thread daniel
On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > This patch adds a missing drm_crtc_vblank_put op to the pair > drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks). > > It clears the execution of the following kms_cursor_crc subtests: > 1.

[PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-22 Thread Melissa Wen
This patch adds a missing drm_crtc_vblank_put op to the pair drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks). It clears the execution of the following kms_cursor_crc subtests: 1. pipe-A-cursor-[size,alpha-opaque, NxN-(on-screen, off-screen, sliding, random, fast-moving])]