Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-22 Thread Julien Cristau
On Tue, Sep 16, 2014 at 09:43:50 -0400, Josh Boyer wrote: > On Fri, Sep 5, 2014 at 1:19 PM, Josh Boyer wrote: > > The userspace drm.h include doesn't prefix the drm directory. This can lead > > to compile failures as /usr/include/drm/ isn't in the standard gcc include > > paths. Fix it to be ,

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-22 Thread Julien Cristau
On Tue, Sep 16, 2014 at 09:43:50 -0400, Josh Boyer wrote: On Fri, Sep 5, 2014 at 1:19 PM, Josh Boyer jwbo...@fedoraproject.org wrote: The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc include

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-16 Thread Dave Airlie
On 16 September 2014 23:43, Josh Boyer wrote: > On Fri, Sep 5, 2014 at 1:19 PM, Josh Boyer wrote: >> The userspace drm.h include doesn't prefix the drm directory. This can lead >> to compile failures as /usr/include/drm/ isn't in the standard gcc include >> paths. Fix it to be , which matches

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-16 Thread Josh Boyer
On Fri, Sep 5, 2014 at 1:19 PM, Josh Boyer wrote: > The userspace drm.h include doesn't prefix the drm directory. This can lead > to compile failures as /usr/include/drm/ isn't in the standard gcc include > paths. Fix it to be , which matches the rest of the driver drm > header files that get

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-16 Thread Josh Boyer
On Fri, Sep 5, 2014 at 1:19 PM, Josh Boyer jwbo...@fedoraproject.org wrote: The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc include paths. Fix it to be drm/drm.h, which matches the rest of the

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-16 Thread Dave Airlie
On 16 September 2014 23:43, Josh Boyer jwbo...@fedoraproject.org wrote: On Fri, Sep 5, 2014 at 1:19 PM, Josh Boyer jwbo...@fedoraproject.org wrote: The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Emil Velikov
On 08/09/14 13:15, Thomas Hellstrom wrote: > Hi! > > On 09/08/2014 02:01 PM, Emil Velikov wrote: [snip] >> >> To the VMware guys, >> >> Any objections if we update the libdrm header and drop the mesa/ddx copies ? >> >> Cheers, >> Emil > Hi! > > vmwgfx libdrm is pretty obsolete and AFAIK not used

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Emil Velikov
On 08/09/14 13:14, Josh Boyer wrote: > On Mon, Sep 8, 2014 at 8:01 AM, Emil Velikov wrote: [snip] >> Any objections if we update the libdrm header and drop the mesa/ddx copies ? >> >> Cheers, >> Emil >> >> P.S. I'm against the patch in any way :) > > Was that meant to say "I'm not against the

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Thomas Hellstrom
Hi! On 09/08/2014 02:01 PM, Emil Velikov wrote: > Hi Josh > > On 05/09/14 18:19, Josh Boyer wrote: >> The userspace drm.h include doesn't prefix the drm directory. This can lead >> to compile failures as /usr/include/drm/ isn't in the standard gcc include >> paths. Fix it to be , which matches

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Josh Boyer
On Mon, Sep 8, 2014 at 8:01 AM, Emil Velikov wrote: > Hi Josh > > On 05/09/14 18:19, Josh Boyer wrote: >> The userspace drm.h include doesn't prefix the drm directory. This can lead >> to compile failures as /usr/include/drm/ isn't in the standard gcc include >> paths. Fix it to be , which

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Emil Velikov
Hi Josh On 05/09/14 18:19, Josh Boyer wrote: > The userspace drm.h include doesn't prefix the drm directory. This can lead > to compile failures as /usr/include/drm/ isn't in the standard gcc include > paths. Fix it to be , which matches the rest of the driver drm > header files that get

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Emil Velikov
Hi Josh On 05/09/14 18:19, Josh Boyer wrote: The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc include paths. Fix it to be drm/drm.h, which matches the rest of the driver drm header files that get

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Josh Boyer
On Mon, Sep 8, 2014 at 8:01 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Hi Josh On 05/09/14 18:19, Josh Boyer wrote: The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc include paths. Fix it to

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Thomas Hellstrom
Hi! On 09/08/2014 02:01 PM, Emil Velikov wrote: Hi Josh On 05/09/14 18:19, Josh Boyer wrote: The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc include paths. Fix it to be drm/drm.h, which matches

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Emil Velikov
On 08/09/14 13:14, Josh Boyer wrote: On Mon, Sep 8, 2014 at 8:01 AM, Emil Velikov emil.l.veli...@gmail.com wrote: [snip] Any objections if we update the libdrm header and drop the mesa/ddx copies ? Cheers, Emil P.S. I'm against the patch in any way :) Was that meant to say I'm not

Re: [PATCH] drm/vmwgfx: Fix drm.h include

2014-09-08 Thread Emil Velikov
On 08/09/14 13:15, Thomas Hellstrom wrote: Hi! On 09/08/2014 02:01 PM, Emil Velikov wrote: [snip] To the VMware guys, Any objections if we update the libdrm header and drop the mesa/ddx copies ? Cheers, Emil Hi! vmwgfx libdrm is pretty obsolete and AFAIK not used by anyone. As

[PATCH] drm/vmwgfx: Fix drm.h include

2014-09-05 Thread Josh Boyer
The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc include paths. Fix it to be , which matches the rest of the driver drm header files that get installed into /usr/include/drm. Red Hat Bugzilla:

[PATCH] drm/vmwgfx: Fix drm.h include

2014-09-05 Thread Josh Boyer
The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc include paths. Fix it to be drm/drm.h, which matches the rest of the driver drm header files that get installed into /usr/include/drm. Red Hat Bugzilla: