Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming

2017-09-20 Thread Daniel Vetter
On Tue, Sep 12, 2017 at 06:54:45PM +0100, Emil Velikov wrote: > On 12 September 2017 at 18:47, Colin Ian King > wrote: > > On 12/09/17 18:42, Thomas Hellstrom wrote: > >> Hi, Colin, > >> > >> On 09/12/2017 07:35 PM, Colin King wrote: > >>> From: Colin Ian King > >>> > >>> mmap'ing the device mul

Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming

2017-09-12 Thread Emil Velikov
On 12 September 2017 at 18:47, Colin Ian King wrote: > On 12/09/17 18:42, Thomas Hellstrom wrote: >> Hi, Colin, >> >> On 09/12/2017 07:35 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> mmap'ing the device multiple times will spam the kernel log with the >>> DRM_ERROR message about illegal

Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming

2017-09-12 Thread Colin Ian King
On 12/09/17 18:42, Thomas Hellstrom wrote: > Hi, Colin, > > On 09/12/2017 07:35 PM, Colin King wrote: >> From: Colin Ian King >> >> mmap'ing the device multiple times will spam the kernel log with the >> DRM_ERROR message about illegal mmap'ing the old fifo space. > How are you hitting this? Mult

Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming

2017-09-12 Thread Thomas Hellstrom
Hi, Colin, On 09/12/2017 07:35 PM, Colin King wrote: From: Colin Ian King mmap'ing the device multiple times will spam the kernel log with the DRM_ERROR message about illegal mmap'ing the old fifo space. How are you hitting this? Multiple mappings should be fine as long as mapping offsets are

[PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming

2017-09-12 Thread Colin King
From: Colin Ian King mmap'ing the device multiple times will spam the kernel log with the DRM_ERROR message about illegal mmap'ing the old fifo space. Since the mmap'ing will fail with an -EINVAL there is no need to emit this message, so just remove it. Signed-off-by: Colin Ian King --- driver