Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Pekka Paalanen
On Mon, 29 Mar 2021 15:36:27 + Simon Ser wrote: > On Monday, March 29th, 2021 at 5:32 PM, Paul Cercueil > wrote: > > > Making the second plane an overlay would break the ABI, which is never > > something I'm happy to do; but I'd prefer to do it now than later. > > Yeah, I wonder if some

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Paul Cercueil
Le lun. 29 mars 2021 à 15:42, Simon Ser a écrit : On Monday, March 29th, 2021 at 5:39 PM, Paul Cercueil wrote: Ok, I read that as "all drivers should provide AT LEAST one primary plane per CRTC", and not as "all drivers should provide ONE AND ONLY ONE primary plane per CRTC". My bad.

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Simon Ser
On Monday, March 29th, 2021 at 5:39 PM, Paul Cercueil wrote: > Ok, I read that as "all drivers should provide AT LEAST one primary > plane per CRTC", and not as "all drivers should provide ONE AND ONLY > ONE primary plane per CRTC". My bad. Yeah, it's a little complicated to document, because i

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Paul Cercueil
Le lun. 29 mars 2021 à 17:35, Maxime Ripard a écrit : On Mon, Mar 29, 2021 at 04:15:28PM +0100, Paul Cercueil wrote: Hi Maxime, Le lun. 29 mars 2021 à 16:07, Maxime Ripard a écrit : > On Sat, Mar 27, 2021 at 11:22:14AM +, Paul Cercueil wrote: > > The ingenic-drm driver has two

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Simon Ser
On Monday, March 29th, 2021 at 5:32 PM, Paul Cercueil wrote: > Making the second plane an overlay would break the ABI, which is never > something I'm happy to do; but I'd prefer to do it now than later. Yeah, I wonder if some user-space depends on this behavior somehow? > I still have concerns

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Maxime Ripard
On Mon, Mar 29, 2021 at 04:15:28PM +0100, Paul Cercueil wrote: > Hi Maxime, > > Le lun. 29 mars 2021 à 16:07, Maxime Ripard a écrit : > > On Sat, Mar 27, 2021 at 11:22:14AM +, Paul Cercueil wrote: > > > The ingenic-drm driver has two mutually exclusive primary planes > > > already; so the f

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Paul Cercueil
Hi Simon, Le lun. 29 mars 2021 à 14:11, Simon Ser a écrit : On Monday, March 29th, 2021 at 4:07 PM, Maxime Ripard wrote: Since it looks like you have two mutually exclusive planes, just expose one and be done with it? You can expose the other as an overlay. Clever user-space will be a

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Paul Cercueil
Le lun. 29 mars 2021 à 17:35, Pekka Paalanen a écrit : On Mon, 29 Mar 2021 12:41:00 +0100 Paul Cercueil wrote: Hi, Le lun. 29 mars 2021 à 11:15, Pekka Paalanen a écrit : > On Sat, 27 Mar 2021 11:26:26 + > Paul Cercueil wrote: > >> It has two mutually exclusive background

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Paul Cercueil
Hi Maxime, Le lun. 29 mars 2021 à 16:07, Maxime Ripard a écrit : On Sat, Mar 27, 2021 at 11:22:14AM +, Paul Cercueil wrote: The ingenic-drm driver has two mutually exclusive primary planes already; so the fact that a CRTC must have one and only one primary plane is an invalid assumptio

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Pekka Paalanen
On Mon, 29 Mar 2021 12:41:00 +0100 Paul Cercueil wrote: > Hi, > > Le lun. 29 mars 2021 à 11:15, Pekka Paalanen a > écrit : > > On Sat, 27 Mar 2021 11:26:26 + > > Paul Cercueil wrote: > > > >> It has two mutually exclusive background planes (same Z level) + one > >> overlay plane. >

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Simon Ser
On Monday, March 29th, 2021 at 4:07 PM, Maxime Ripard wrote: > Since it looks like you have two mutually exclusive planes, just expose > one and be done with it? You can expose the other as an overlay. Clever user-space will be able to figure out that the more advanced plane can be used if the p

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Maxime Ripard
On Sat, Mar 27, 2021 at 11:22:14AM +, Paul Cercueil wrote: > The ingenic-drm driver has two mutually exclusive primary planes > already; so the fact that a CRTC must have one and only one primary > plane is an invalid assumption. I mean, no? It's been documented for a while that a CRTC should

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Paul Cercueil
Hi, Le lun. 29 mars 2021 à 11:15, Pekka Paalanen a écrit : On Sat, 27 Mar 2021 11:26:26 + Paul Cercueil wrote: It has two mutually exclusive background planes (same Z level) + one overlay plane. What's the difference between the two background planes? How will generic userspace kno

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-29 Thread Pekka Paalanen
On Sat, 27 Mar 2021 11:26:26 + Paul Cercueil wrote: > It has two mutually exclusive background planes (same Z level) + one > overlay plane. What's the difference between the two background planes? How will generic userspace know to pick the "right" one? Thanks, pq > Le sam. 27 mars 2021

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-27 Thread Paul Cercueil
It has two mutually exclusive background planes (same Z level) + one overlay plane. -Paul Le sam. 27 mars 2021 à 11:24, Simon Ser a écrit : On Saturday, March 27th, 2021 at 12:22 PM, Paul Cercueil wrote: The ingenic-drm driver has two mutually exclusive primary planes already; so the

Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-27 Thread Simon Ser
On Saturday, March 27th, 2021 at 12:22 PM, Paul Cercueil wrote: > The ingenic-drm driver has two mutually exclusive primary planes > already; so the fact that a CRTC must have one and only one primary > plane is an invalid assumption. Why does this driver expose two primary planes, if it only h

[PATCH] drm: DON'T require each CRTC to have a unique primary plane

2021-03-27 Thread Paul Cercueil
The ingenic-drm driver has two mutually exclusive primary planes already; so the fact that a CRTC must have one and only one primary plane is an invalid assumption. Fixes: 96962e3de725 ("drm: require each CRTC to have a unique primary plane") Cc: # 5.11 Signed-off-by: Paul Cercueil --- drivers/