From: Randy Dunlap <rdun...@infradead.org> A single driver should not enable (select) an entire subsystem, such as INPUT, so change the 'select' to "depends on".
Fixes: d6abe6df706c ("drm/bridge: sil_sii8620: do not have a dependency of RC_CORE") Signed-off-by: Randy Dunlap <rdun...@infradead.org> Cc: Inki Dae <inki....@samsung.com> Cc: Andrzej Hajda <a.ha...@samsung.com> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Cc: dri-de...@lists.freedesktop.org --- Linus has written this a couple of times in the last 15 years or so, but my search fu cannot find it. And there are a few drivers in the kernel tree that do this, but we shouldn't be adding more that do so. drivers/gpu/drm/bridge/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- lnx-52-rc7.orig/drivers/gpu/drm/bridge/Kconfig +++ lnx-52-rc7/drivers/gpu/drm/bridge/Kconfig @@ -83,10 +83,9 @@ config DRM_PARADE_PS8622 config DRM_SIL_SII8620 tristate "Silicon Image SII8620 HDMI/MHL bridge" - depends on OF + depends on OF && INPUT select DRM_KMS_HELPER imply EXTCON - select INPUT select RC_CORE help Silicon Image SII8620 HDMI/MHL bridge chip driver.