Re: [PATCH] drm: refactor call to request_module

2013-05-08 Thread Kees Cook
On Wed, May 8, 2013 at 12:22 AM, Paul Menzel wrote: > Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook: >> This reduces the size of the stack frame when calling request_module(). >> Performing the sprintf before the call is not needed. > > Good fine. Do you have any hard numbers for the

Re: [PATCH] drm: refactor call to request_module

2013-05-08 Thread Paul Menzel
Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook: > This reduces the size of the stack frame when calling request_module(). > Performing the sprintf before the call is not needed. Good fine. Do you have any hard numbers for the record? Did you find this just by reading the code or are

Re: [PATCH] drm: refactor call to request_module

2013-05-08 Thread Paul Menzel
Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook: This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Good fine. Do you have any hard numbers for the record? Did you find this just by reading the code or are

Re: [PATCH] drm: refactor call to request_module

2013-05-08 Thread Kees Cook
On Wed, May 8, 2013 at 12:22 AM, Paul Menzel paulepan...@users.sourceforge.net wrote: Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook: This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Good fine. Do you

[PATCH] drm: refactor call to request_module

2013-05-07 Thread Kees Cook
This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook --- drivers/gpu/drm/drm_encoder_slave.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH] drm: refactor call to request_module

2013-05-07 Thread Kees Cook
This reduces the size of the stack frame when calling request_module(). Performing the sprintf before the call is not needed. Signed-off-by: Kees Cook keesc...@chromium.org --- drivers/gpu/drm/drm_encoder_slave.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git