Re: [PATCH] drm: remove redundant assignment to variable 'ret'

2020-07-16 Thread Daniel Vetter
On Thu, Jul 16, 2020 at 09:59:38AM +0800, Jing Xiangfeng wrote: > > > On 2020/7/15 20:05, Daniel Vetter wrote: > > On Wed, Jul 15, 2020 at 03:05:59PM +0800, Jing Xiangfeng wrote: > > > The variable ret has been assigned the value '-EINVAL'. The assignment > > > in the if() is redundant. We can re

Re: [PATCH] drm: remove redundant assignment to variable 'ret'

2020-07-15 Thread Jing Xiangfeng
On 2020/7/15 20:05, Daniel Vetter wrote: On Wed, Jul 15, 2020 at 03:05:59PM +0800, Jing Xiangfeng wrote: The variable ret has been assigned the value '-EINVAL'. The assignment in the if() is redundant. We can remove it. Nope, that's not correct. Before this assignement ret is guaranteed to

Re: [PATCH] drm: remove redundant assignment to variable 'ret'

2020-07-15 Thread Daniel Vetter
On Wed, Jul 15, 2020 at 03:05:59PM +0800, Jing Xiangfeng wrote: > The variable ret has been assigned the value '-EINVAL'. The assignment > in the if() is redundant. We can remove it. Nope, that's not correct. Before this assignement ret is guaranteed to be 0. -Daniel > > Signed-off-by: Jing Xian

[PATCH] drm: remove redundant assignment to variable 'ret'

2020-07-15 Thread Jing Xiangfeng
The variable ret has been assigned the value '-EINVAL'. The assignment in the if() is redundant. We can remove it. Signed-off-by: Jing Xiangfeng --- drivers/gpu/drm/drm_auth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c index 800ac39