[patch] drm missing memset can crash X server..

2005-03-09 Thread Dave Airlie
Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it down to a missing memset in the setversion ioctl, this causes X server crashes... From: Egbert Eich <[EMAIL PROTECTED]> Signed-off-by: Dave Airlie <[EMAIL PROTECTED]> diff -Nru a/drivers/char/drm/drm_ioctl.c

Re: [patch] drm missing memset can crash X server..

2005-03-09 Thread Chris Wright
* Dave Airlie ([EMAIL PROTECTED]) wrote: > > Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it > down to a missing memset in the setversion ioctl, this causes X server > crashes... > > From: Egbert Eich <[EMAIL PROTECTED]> > Signed-off-by: Dave Airlie <[EMAIL PROTECTED]>

Re: [PATCH] drm missing memset can crash X server...

2005-03-09 Thread Dave Airlie
> > Could you please add Signed-off-by? Do I read this patch correctly that > it effectively disables the DRM_COPY in ->version callbacks? I'll resend the patch now .. no it just zeros out the structure on the stack so that the version callback doesn't get a garbage structure to copy into...

Re: [PATCH] drm missing memset can crash X server...

2005-03-09 Thread Dave Airlie
Could you please add Signed-off-by? Do I read this patch correctly that it effectively disables the DRM_COPY in -version callbacks? I'll resend the patch now .. no it just zeros out the structure on the stack so that the version callback doesn't get a garbage structure to copy into... Dave.

Re: [patch] drm missing memset can crash X server..

2005-03-09 Thread Chris Wright
* Dave Airlie ([EMAIL PROTECTED]) wrote: Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it down to a missing memset in the setversion ioctl, this causes X server crashes... From: Egbert Eich [EMAIL PROTECTED] Signed-off-by: Dave Airlie [EMAIL PROTECTED] Thanks,

[patch] drm missing memset can crash X server..

2005-03-09 Thread Dave Airlie
Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it down to a missing memset in the setversion ioctl, this causes X server crashes... From: Egbert Eich [EMAIL PROTECTED] Signed-off-by: Dave Airlie [EMAIL PROTECTED] diff -Nru a/drivers/char/drm/drm_ioctl.c

Re: [PATCH] drm missing memset can crash X server...

2005-03-08 Thread Chris Wright
* Dave Airlie ([EMAIL PROTECTED]) wrote: > > Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it > down to a missing memset in the setversion ioctl, this causes X server > crashes so I would like to see the fix in a 2.6.11.x tree if possible.. Could you please add

[PATCH] drm missing memset can crash X server...

2005-03-08 Thread Dave Airlie
Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it down to a missing memset in the setversion ioctl, this causes X server crashes so I would like to see the fix in a 2.6.11.x tree if possible.. Regards, Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied

[PATCH] drm missing memset can crash X server...

2005-03-08 Thread Dave Airlie
Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it down to a missing memset in the setversion ioctl, this causes X server crashes so I would like to see the fix in a 2.6.11.x tree if possible.. Regards, Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied

Re: [PATCH] drm missing memset can crash X server...

2005-03-08 Thread Chris Wright
* Dave Airlie ([EMAIL PROTECTED]) wrote: Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it down to a missing memset in the setversion ioctl, this causes X server crashes so I would like to see the fix in a 2.6.11.x tree if possible.. Could you please add Signed-off-by?