Re: [PATCH] drm_aux-dev: fix error handling in drm_dp_aux_dev_init()

2016-09-23 Thread Alexey Khoroshilov
Dear Daniel, Sorry for long response. > Applied to drm-misc, thanks for the patch. Out of curiosity, how > exactly did you spot this bug? We use static analysis tools that check various rules on correct usage of kernel core API. An example of error trace for the rm_dp_aux_dev case you can see he

Re: [PATCH] drm_aux-dev: fix error handling in drm_dp_aux_dev_init()

2016-07-12 Thread Daniel Vetter
On Thu, Jun 30, 2016 at 12:52:15AM +0300, Alexey Khoroshilov wrote: > If class_create() fails, there is no need for class_destroy(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Applied to drm-misc, thanks for the patch. Out of curiosi

[PATCH] drm_aux-dev: fix error handling in drm_dp_aux_dev_init()

2016-06-29 Thread Alexey Khoroshilov
If class_create() fails, there is no need for class_destroy(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/gpu/drm/drm_dp_aux_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_aux_d