Re: [PATCH] ds1337 3/4

2005-04-08 Thread Ladislav Michl
On Fri, Apr 08, 2005 at 12:08:38PM +0200, Jean Delvare wrote: > Looks OK to me. Ok, I have few more fixes for this driver and will send them later when I find time to split them out into smaller chunks. Again, here is patch with signed off line. dev_{dbg,err} functions should print client's devi

Re: [PATCH] ds1337 3/4

2005-04-08 Thread Jean Delvare
Hi Ladislav, > dev_{dbg,err} functions should print client's device name. data->id can > be dropped from message, because device is determined by bus it hangs on > (it has fixed address). Looks OK to me. Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-k

[PATCH] ds1337 3/4

2005-04-07 Thread Ladislav Michl
dev_{dbg,err} functions should print client's device name. data->id can be dropped from message, because device is determined by bus it hangs on (it has fixed address). --- linux-omap/drivers/i2c/chips/ds1337.c.orig 2005-04-08 00:36:15.072302800 +0200 +++ linux-omap/drivers/i2c/chips/ds1337.c