Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-15 Thread Rob Herring
On Tue, 08 Sep 2020 16:59:00 +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-09 Thread Tim Harvey
On Tue, Sep 8, 2020 at 7:59 AM Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW =

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-09 Thread Vaittinen, Matti
On Wed, 2020-09-09 at 11:20 +0200, k...@kernel.org wrote: > On Wed, Sep 09, 2020 at 08:57:36AM +, Vaittinen, Matti wrote: > > Hello Krzysztof, > > > > On Wed, 2020-09-09 at 10:17 +0200, k...@kernel.org wrote: > > > On Wed, Sep 09, 2020 at 06:30:44AM +, Vaittinen, Matti wrote: > > > > On Tu

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-09 Thread k...@kernel.org
On Wed, Sep 09, 2020 at 08:57:36AM +, Vaittinen, Matti wrote: > Hello Krzysztof, > > On Wed, 2020-09-09 at 10:17 +0200, k...@kernel.org wrote: > > On Wed, Sep 09, 2020 at 06:30:44AM +, Vaittinen, Matti wrote: > > > On Tue, 2020-09-08 at 16:59 +0200, Krzysztof Kozlowski wrote: > > > > GPIO_

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-09 Thread Vaittinen, Matti
Hello Krzysztof, On Wed, 2020-09-09 at 10:17 +0200, k...@kernel.org wrote: > On Wed, Sep 09, 2020 at 06:30:44AM +, Vaittinen, Matti wrote: > > On Tue, 2020-09-08 at 16:59 +0200, Krzysztof Kozlowski wrote: > > > GPIO_ACTIVE_x flags are not correct in the context of interrupt > > > flags. > > >

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-09 Thread k...@kernel.org
On Wed, Sep 09, 2020 at 06:30:44AM +, Vaittinen, Matti wrote: > > On Tue, 2020-09-08 at 16:59 +0200, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt > > flags. > > These are simple defines so they could be used in DTS but they will > > not > > hav

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-08 Thread Vaittinen, Matti
On Tue, 2020-09-08 at 16:59 +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt > flags. > These are simple defines so they could be used in DTS but they will > not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_L

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-08 Thread Lee Jones
On Tue, 08 Sep 2020, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE

[PATCH] dt-bindings: mfd: Correct interrupt flags in examples

2020-09-08 Thread Krzysztof Kozlowski
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING Correct the interrupt flags, assuming the aut