Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-14 Thread Stephen Rothwell
Hi Steve, On Wed, 14 Mar 2018 19:42:37 -0400 Steven Rostedt wrote: > > I still would like to keep it in lib. If blackfin is going to be nuked > in 4.17, and nds32 is the only one that is causing a issue. I would > highly recommend fixing nds32 and have Stephen stop building blackfin. nds32 was "

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-14 Thread Steven Rostedt
On Fri, 9 Mar 2018 10:50:55 +0100 Petr Mladek wrote: > On Wed 2018-03-07 20:48:56, Sergey Senozhatsky wrote: > > On (03/07/18 11:57), Arnd Bergmann wrote: > > > Since lib/dump_stack.c is mandatory then, I would suggest making it > > > obj-y and moving it out of lib/ into kernel/printk/. > >

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-09 Thread Petr Mladek
On Wed 2018-03-07 20:48:56, Sergey Senozhatsky wrote: > On (03/07/18 11:57), Arnd Bergmann wrote: > > Since lib/dump_stack.c is mandatory then, I would suggest making it > > obj-y and moving it out of lib/ into kernel/printk/. > > Totally agree on obj-y. And tend to agree on moving lib/dump_stack

Re: CRIS port status, was: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-08 Thread Jesper Nilsson
On Wed, Mar 07, 2018 at 03:09:27PM +0100, Arnd Bergmann wrote: > On Wed, Mar 7, 2018 at 2:40 PM, Sergey Senozhatsky > wrote: > > On (03/07/18 13:48), Arnd Bergmann wrote: > > [..] > >> > > >> > I can easily stop building blackfin - and, if the intention is to > >> > remove it, there is not much po

Re: CRIS port status, was: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Arnd Bergmann
On Wed, Mar 7, 2018 at 4:01 PM, Michal Simek wrote: > On 7.3.2018 15:09, Arnd Bergmann wrote: >> On Wed, Mar 7, 2018 at 2:40 PM, Sergey Senozhatsky >> wrote: >> If we remove cris, it's probably also appropriate to ask the question >> about microblaze: Michal, I know your work on microblaze linux

Re: CRIS port status, was: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Michal Simek
Hi Arnd, On 7.3.2018 15:09, Arnd Bergmann wrote: > On Wed, Mar 7, 2018 at 2:40 PM, Sergey Senozhatsky > wrote: >> On (03/07/18 13:48), Arnd Bergmann wrote: >> [..] I can easily stop building blackfin - and, if the intention is to remove it, there is not much point in wasting resour

CRIS port status, was: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Arnd Bergmann
On Wed, Mar 7, 2018 at 2:40 PM, Sergey Senozhatsky wrote: > On (03/07/18 13:48), Arnd Bergmann wrote: > [..] >> > >> > I can easily stop building blackfin - and, if the intention is to >> > remove it, there is not much point in wasting resources building it any >> > anyway. >> >> Right. At the mom

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Sergey Senozhatsky
Hi, On (03/07/18 23:41), Stephen Rothwell wrote: [..] > > OK. Petr, Stephen, what would be your preference? > > I can easily stop building blackfin - and, if the intention is to > remove it, there is not much point in wasting resources building it any > anyway. OK, sounds good to me. Then we ca

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Sergey Senozhatsky
On (03/07/18 13:48), Arnd Bergmann wrote: [..] > > > > I can easily stop building blackfin - and, if the intention is to > > remove it, there is not much point in wasting resources building it any > > anyway. > > Right. At the moment, the plan is to remove metag, score, unicore32, > m32r, frv and

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Stephen Rothwell
Hi Arnd, On Wed, 7 Mar 2018 13:58:13 +0100 Arnd Bergmann wrote: > > On Wed, Mar 7, 2018 at 1:53 PM, Stephen Rothwell > wrote: > > Hi Arnd, > > > > On Wed, 7 Mar 2018 13:48:09 +0100 Arnd Bergmann wrote: > >> > >> Right. At the moment, the plan is to remove metag, score, unicore32, > >> m32r,

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Arnd Bergmann
On Wed, Mar 7, 2018 at 1:53 PM, Stephen Rothwell wrote: > Hi Arnd, > > On Wed, 7 Mar 2018 13:48:09 +0100 Arnd Bergmann wrote: >> >> Right. At the moment, the plan is to remove metag, score, unicore32, >> m32r, frv and blackfin. If you are building any more of those, you can >> stop that as well.

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Stephen Rothwell
Hi Arnd, On Wed, 7 Mar 2018 13:48:09 +0100 Arnd Bergmann wrote: > > Right. At the moment, the plan is to remove metag, score, unicore32, > m32r, frv and blackfin. If you are building any more of those, you can > stop that as well. OK, thanks. Will I get a tree with those removal commits in linu

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Arnd Bergmann
On Wed, Mar 7, 2018 at 1:41 PM, Stephen Rothwell wrote: > Hi Sergey, > > On Wed, 7 Mar 2018 20:48:56 +0900 Sergey Senozhatsky > wrote: >> >> On (03/07/18 11:57), Arnd Bergmann wrote: >> [..] >> > >> Originally I planned to wait a few more releases, but the last >> > >> maintainer >> > >> has co

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Stephen Rothwell
Hi Sergey, On Wed, 7 Mar 2018 20:48:56 +0900 Sergey Senozhatsky wrote: > > On (03/07/18 11:57), Arnd Bergmann wrote: > [..] > > >> Originally I planned to wait a few more releases, but the last maintainer > > >> has commented that he will now send a patch for immediate removal, > > >> so 4.17 is

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Sergey Senozhatsky
On (03/07/18 11:57), Arnd Bergmann wrote: [..] > >> Originally I planned to wait a few more releases, but the last maintainer > >> has commented that he will now send a patch for immediate removal, > >> so 4.17 is almost certain at this point. > > > > Would be great to get it removed as soon as pos

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Arnd Bergmann
On Wed, Mar 7, 2018 at 11:40 AM, Sergey Senozhatsky wrote: > On (03/07/18 09:46), Arnd Bergmann wrote: >> > >> > When is this going to happen? 4.17? >> >> Originally I planned to wait a few more releases, but the last maintainer >> has commented that he will now send a patch for immediate removal,

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Sergey Senozhatsky
On (03/07/18 09:46), Arnd Bergmann wrote: > > > > When is this going to happen? 4.17? > > Originally I planned to wait a few more releases, but the last maintainer > has commented that he will now send a patch for immediate removal, > so 4.17 is almost certain at this point. Would be great to get

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Arnd Bergmann
On Wed, Mar 7, 2018 at 10:44 AM, Greentime Hu wrote: > 2018-03-07 17:09 GMT+08:00 Petr Mladek : >> Ah, there was a mid-air collision. Arnd already answered most of my >> questions and even more. >> >> On Wed 2018-03-07 09:46:27, Arnd Bergmann wrote: >>> On Wed, Mar 7, 2018 at 3:21 AM, Sergey Senoz

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Greentime Hu
2018-03-07 17:09 GMT+08:00 Petr Mladek : > Ah, there was a mid-air collision. Arnd already answered most of my > questions and even more. > > On Wed 2018-03-07 09:46:27, Arnd Bergmann wrote: >> On Wed, Mar 7, 2018 at 3:21 AM, Sergey Senozhatsky >> wrote: >> > On (03/06/18 14:27), Arnd Bergmann wro

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Petr Mladek
Ah, there was a mid-air collision. Arnd already answered most of my questions and even more. On Wed 2018-03-07 09:46:27, Arnd Bergmann wrote: > On Wed, Mar 7, 2018 at 3:21 AM, Sergey Senozhatsky > wrote: > > On (03/06/18 14:27), Arnd Bergmann wrote: > >> Weak symbols are generally discouraged in

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Petr Mladek
On Wed 2018-03-07 11:21:27, Sergey Senozhatsky wrote: > Hello Arnd, > > On (03/06/18 14:27), Arnd Bergmann wrote: > [..] > > As we are now removing blackfin, based on the latest discussion, this > > part should no longer be necessary. > > When is this going to happen? 4.17? > > [..] > > nds32 cu

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-07 Thread Arnd Bergmann
On Wed, Mar 7, 2018 at 3:21 AM, Sergey Senozhatsky wrote: > Hello Arnd, > > On (03/06/18 14:27), Arnd Bergmann wrote: > [..] >> As we are now removing blackfin, based on the latest discussion, this >> part should no longer be necessary. > > When is this going to happen? 4.17? Originally I planned

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-06 Thread Sergey Senozhatsky
Hello Arnd, On (03/06/18 14:27), Arnd Bergmann wrote: [..] > As we are now removing blackfin, based on the latest discussion, this > part should no longer be necessary. When is this going to happen? 4.17? [..] > nds32 currently only exists in linux-next, not in the mainline kernel. > If it's the

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-06 Thread Stephen Rothwell
Hi all, On Tue, 6 Mar 2018 13:43:26 +0100 Petr Mladek wrote: > > Greentime Hu, > > the for-4.17 branch in printk.git is based on Linus' tree. Therefore > I had to remove the hunk against arch/nds32/kernel/traps.c because > this file is only in linux-next. > > I think that it might be easier if

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-06 Thread Arnd Bergmann
On Mon, Mar 5, 2018 at 6:37 AM, Sergey Senozhatsky wrote: > We want to move dump_stack related functions out of printk C > code and consolidate them in lib/dump_stack file. The reason why > dump_stack_print_info()/etc ended up in printk.c was a "generic" > (dummy) lib dump_stack() function, which

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-06 Thread Petr Mladek
On Tue 2018-03-06 13:29:57, Sergey Senozhatsky wrote: > On (03/05/18 15:48), Petr Mladek wrote: > [..] > > > > I hope that I did not miss anything. I could not try this at > > runtime. > > I think you can. The rules are universal, you can do on x86 > something like this > > --- > > arch/x86/ke

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-05 Thread Greentime Hu
2018-03-06 12:31 GMT+08:00 Sergey Senozhatsky : > On (03/06/18 10:50), Greentime Hu wrote: > [..] >> > Greentime Hu, you tested this on nds32. Could I use your Tested-by, >> > please? >> > >> >> Yes, please use it. :) > > Thanks. > > To be sure, is this > > Tested-by: Greentime Hu # nds32 > or >

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-05 Thread Sergey Senozhatsky
On (03/06/18 10:50), Greentime Hu wrote: [..] > > Greentime Hu, you tested this on nds32. Could I use your Tested-by, > > please? > > > > Yes, please use it. :) Thanks. To be sure, is this Tested-by: Greentime Hu # nds32 or Acked-by: Greentime Hu # nds32 ? -ss

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-05 Thread Sergey Senozhatsky
On (03/05/18 15:48), Petr Mladek wrote: [..] > > I hope that I did not miss anything. I could not try this at > runtime. I think you can. The rules are universal, you can do on x86 something like this --- arch/x86/kernel/dumpstack.c | 13 + 1 file changed, 13 insertions(+) diff --

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-05 Thread Greentime Hu
2018-03-05 22:48 GMT+08:00 Petr Mladek : > On Mon 2018-03-05 14:37:42, Sergey Senozhatsky wrote: >> We want to move dump_stack related functions out of printk C >> code and consolidate them in lib/dump_stack file. The reason why >> dump_stack_print_info()/etc ended up in printk.c was a "generic" >>

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-05 Thread Petr Mladek
On Mon 2018-03-05 14:37:42, Sergey Senozhatsky wrote: > We want to move dump_stack related functions out of printk C > code and consolidate them in lib/dump_stack file. The reason why > dump_stack_print_info()/etc ended up in printk.c was a "generic" > (dummy) lib dump_stack() function, which archs

[PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-04 Thread Sergey Senozhatsky
We want to move dump_stack related functions out of printk C code and consolidate them in lib/dump_stack file. The reason why dump_stack_print_info()/etc ended up in printk.c was a "generic" (dummy) lib dump_stack() function, which archs can override. For example, blackfin and nds32, define their o