Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Baolin Wang
On 26 May 2016 at 18:27, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> On 26 May 2016 at 17:45, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Baolin Wang writes: >>> >>> >>> > Also note that the

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Baolin Wang
On 26 May 2016 at 18:27, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> On 26 May 2016 at 17:45, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Baolin Wang writes: >>> >>> >>> > Also note that the usb_endpoint_xfer_isoc() call on line 2067 of > gadget.c (as in my testing/next from

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Felipe Balbi
Hi, Baolin Wang writes: > On 26 May 2016 at 17:45, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >> >> >> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of gadget.c (as in my testing/next

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Felipe Balbi
Hi, Baolin Wang writes: > On 26 May 2016 at 17:45, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >> >> >> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of gadget.c (as in my testing/next from today) won't even get executed, so we're safe there. >>>

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Baolin Wang
On 26 May 2016 at 17:45, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: > > > >>> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of >>> gadget.c (as in my testing/next from today) won't even get executed, so >>> we're safe there. >>

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Baolin Wang
On 26 May 2016 at 17:45, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: > > > >>> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of >>> gadget.c (as in my testing/next from today) won't even get executed, so >>> we're safe there. >> >> Never will be executed? then we can

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Felipe Balbi
Hi, Baolin Wang writes: >> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of >> gadget.c (as in my testing/next from today) won't even get executed, so >> we're safe there. > > Never will be executed? then we can remove the > usb_endpoint_xfer_isoc()

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Felipe Balbi
Hi, Baolin Wang writes: >> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of >> gadget.c (as in my testing/next from today) won't even get executed, so >> we're safe there. > > Never will be executed? then we can remove the > usb_endpoint_xfer_isoc() (line 2025) at risk? > >

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Baolin Wang
Hi, On 26 May 2016 at 15:48, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Hi Felipe, >> >> On 26 May 2016 at 14:22, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Baolin Wang writes: When handling the

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Baolin Wang
Hi, On 26 May 2016 at 15:48, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> Hi Felipe, >> >> On 26 May 2016 at 14:22, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Baolin Wang writes: When handling the endpoint interrupt handler, it maybe disable the endpoint from another core

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Felipe Balbi
Hi, Baolin Wang writes: > Hi Felipe, > > On 26 May 2016 at 14:22, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>> When handling the endpoint interrupt handler, it maybe disable the endpoint >>> from another core

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Felipe Balbi
Hi, Baolin Wang writes: > Hi Felipe, > > On 26 May 2016 at 14:22, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>> When handling the endpoint interrupt handler, it maybe disable the endpoint >>> from another core user to set the USB endpoint descriptor pointor to be NULL >>> while

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Baolin Wang
Hi Felipe, On 26 May 2016 at 14:22, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> When handling the endpoint interrupt handler, it maybe disable the endpoint >> from another core user to set the USB endpoint descriptor pointor to be NULL >>

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Baolin Wang
Hi Felipe, On 26 May 2016 at 14:22, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> When handling the endpoint interrupt handler, it maybe disable the endpoint >> from another core user to set the USB endpoint descriptor pointor to be NULL >> while issuing usb_gadget_giveback_request()

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Felipe Balbi
Hi, Baolin Wang writes: > When handling the endpoint interrupt handler, it maybe disable the endpoint > from another core user to set the USB endpoint descriptor pointor to be NULL > while issuing usb_gadget_giveback_request() function to release lock. So it > will be

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-26 Thread Felipe Balbi
Hi, Baolin Wang writes: > When handling the endpoint interrupt handler, it maybe disable the endpoint > from another core user to set the USB endpoint descriptor pointor to be NULL > while issuing usb_gadget_giveback_request() function to release lock. So it > will be one bug to check the

[PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-25 Thread Baolin Wang
When handling the endpoint interrupt handler, it maybe disable the endpoint from another core user to set the USB endpoint descriptor pointor to be NULL while issuing usb_gadget_giveback_request() function to release lock. So it will be one bug to check the endpoint type by usb_endpoint_xfer_xxx()

[PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

2016-05-25 Thread Baolin Wang
When handling the endpoint interrupt handler, it maybe disable the endpoint from another core user to set the USB endpoint descriptor pointor to be NULL while issuing usb_gadget_giveback_request() function to release lock. So it will be one bug to check the endpoint type by usb_endpoint_xfer_xxx()