ntel.com; Kirsher, Jeffrey T;
> net...@vger.kernel.org; Wyborny, Carolyn; j...@isotope.jf.intel.com;
> linux-kernel@vger.kernel.org
> Subject: Re: [linux-nics] [PATCH] e1000: remove unused variables
>
> On Sun, Nov 30, 2014 at 01:45:13AM +, Ben Hutchings wrote:
> > On Wed, 2014-11-26 at 21:59
kernel.org
Subject: Re: [linux-nics] [PATCH] e1000: remove unused variables
On Sun, Nov 30, 2014 at 01:45:13AM +, Ben Hutchings wrote:
> On Wed, 2014-11-26 at 21:59 -0800, Hisashi T Fujinaka wrote:
> > I'm pretty sure those double reads are there for a reason, so most
> > of t
On Sun, Nov 30, 2014 at 01:45:13AM +, Ben Hutchings wrote:
> On Wed, 2014-11-26 at 21:59 -0800, Hisashi T Fujinaka wrote:
> > I'm pretty sure those double reads are there for a reason, so most of
> > this I'm going to have to check on Monday. We have a long holiday
> > weekend here in the US.
>
On Wed, 2014-11-26 at 21:59 -0800, Hisashi T Fujinaka wrote:
> I'm pretty sure those double reads are there for a reason, so most of
> this I'm going to have to check on Monday. We have a long holiday
> weekend here in the US.
[...]
If there were double register reads being replaced with single re
On 29.11.2014 00:28, Florian Fainelli wrote:
> Also, if you do a read that is not stored in any return value, the
> compiler is now free to remove that actual read,
This does not apply to reads from iomem (see "volatile" specifier in
readl()).
Regards,
Lino
--
To unsubscribe from this list: se
Le 27/11/2014 05:07, Sudip Mukherjee a écrit :
> On Wed, Nov 26, 2014 at 09:59:28PM -0800, Hisashi T Fujinaka wrote:
>> I'm pretty sure those double reads are there for a reason, so most of
>> this I'm going to have to check on Monday. We have a long holiday
>> weekend here in the US.
>
> if the d
On Wed, Nov 26, 2014 at 09:59:28PM -0800, Hisashi T Fujinaka wrote:
> I'm pretty sure those double reads are there for a reason, so most of
> this I'm going to have to check on Monday. We have a long holiday
> weekend here in the US.
if the double reads are there for some reason, can you please le
I'm pretty sure those double reads are there for a reason, so most of
this I'm going to have to check on Monday. We have a long holiday
weekend here in the US.
I'm not sure why you're bothering with an old driver like this, but if
you haven't actually tried this on all the hardware it pertains to
these variables were only being assigned some values, but were never
used.
Signed-off-by: Sudip Mukherjee
---
drivers/net/ethernet/intel/e1000/e1000_hw.c | 142 --
drivers/net/ethernet/intel/e1000/e1000_main.c | 3 -
2 files changed, 66 insertions(+), 79 deletions(-)
9 matches
Mail list logo