RE: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Xie Shaohui-B21989
.com; linux- > ker...@vger.kernel.org; grant.lik...@secretlab.ca > Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe > > On Wed, Sep 19, 2012 at 03:43:35AM +, Xie Shaohui-B21989 wrote: > > > On Mon, Sep 17, 2012 at 10:32:59AM +, Xie Shaohui-B21989 wrote: &

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Shaun Ruffell
On Wed, Sep 19, 2012 at 03:43:35AM +, Xie Shaohui-B21989 wrote: > > On Mon, Sep 17, 2012 at 10:32:59AM +, Xie Shaohui-B21989 wrote: > > > > > > BTW: seems you are using a different kernel tree with mine. > > > > On the chance that I missing something important: Why do you say > > I was

RE: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Xie Shaohui-B21989
.com; linux- > ker...@vger.kernel.org; grant.lik...@secretlab.ca > Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe > > On Mon, Sep 17, 2012 at 10:32:59AM +, Xie Shaohui-B21989 wrote: > > > -Original Message- > > > From: Shaun Ruffell [mailto:sruff..

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Shaun Ruffell
linuxppc-...@lists.ozlabs.org; > > a...@linux-foundation.org; avoront...@mvista.com; linux- > > ker...@vger.kernel.org; grant.lik...@secretlab.ca > > Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe > > > > On Thu, Sep 13, 2012 at 06:55:29PM +0800,

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Shaun Ruffell
-foundation.org; avoront...@mvista.com; linux- ker...@vger.kernel.org; grant.lik...@secretlab.ca Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote: Error handle in case of DDR ECC off is wrong, sysfs entries

RE: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Xie Shaohui-B21989
; grant.lik...@secretlab.ca Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe On Mon, Sep 17, 2012 at 10:32:59AM +, Xie Shaohui-B21989 wrote: -Original Message- From: Shaun Ruffell [mailto:sruff...@digium.com] Sent: Saturday, September 15, 2012 2:22 AM

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Shaun Ruffell
On Wed, Sep 19, 2012 at 03:43:35AM +, Xie Shaohui-B21989 wrote: On Mon, Sep 17, 2012 at 10:32:59AM +, Xie Shaohui-B21989 wrote: BTW: seems you are using a different kernel tree with mine. On the chance that I missing something important: Why do you say I was running a

RE: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-18 Thread Xie Shaohui-B21989
; grant.lik...@secretlab.ca Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe On Wed, Sep 19, 2012 at 03:43:35AM +, Xie Shaohui-B21989 wrote: On Mon, Sep 17, 2012 at 10:32:59AM +, Xie Shaohui-B21989 wrote: BTW: seems you are using a different kernel tree

RE: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-17 Thread Xie Shaohui-B21989
er...@vger.kernel.org; grant.lik...@secretlab.ca > Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe > > On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote: > > Error handle in case of DDR ECC off is wrong, sysfs entries have not > > been

RE: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-17 Thread Xie Shaohui-B21989
; grant.lik...@secretlab.ca Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote: Error handle in case of DDR ECC off is wrong, sysfs entries have not been created, so edac_mc_free which frees a mci instance should

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-14 Thread Shaun Ruffell
On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote: > Error handle in case of DDR ECC off is wrong, sysfs entries have not been > created, so edac_mc_free which frees a mci instance should not be called. > Also, free mci's memory in this case. Jus FYI: I ran into the same error in

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-14 Thread Shaun Ruffell
On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote: Error handle in case of DDR ECC off is wrong, sysfs entries have not been created, so edac_mc_free which frees a mci instance should not be called. Also, free mci's memory in this case. Jus FYI: I ran into the same error in

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-13 Thread Kim Phillips
On Thu, 13 Sep 2012 18:55:29 +0800 Shaohui Xie wrote: > Error handle in case of DDR ECC off is wrong, sysfs entries have not been > created, so edac_mc_free which frees a mci instance should not be called. > Also, free mci's memory in this case. > > Signed-off-by: Shaohui Xie > --- this fixes

[PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-13 Thread Shaohui Xie
Error handle in case of DDR ECC off is wrong, sysfs entries have not been created, so edac_mc_free which frees a mci instance should not be called. Also, free mci's memory in this case. Signed-off-by: Shaohui Xie --- drivers/edac/edac_core.h|1 + drivers/edac/edac_mc.c | 53

[PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-13 Thread Shaohui Xie
Error handle in case of DDR ECC off is wrong, sysfs entries have not been created, so edac_mc_free which frees a mci instance should not be called. Also, free mci's memory in this case. Signed-off-by: Shaohui Xie shaohui@freescale.com --- drivers/edac/edac_core.h|1 +

Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

2012-09-13 Thread Kim Phillips
On Thu, 13 Sep 2012 18:55:29 +0800 Shaohui Xie shaohui@freescale.com wrote: Error handle in case of DDR ECC off is wrong, sysfs entries have not been created, so edac_mc_free which frees a mci instance should not be called. Also, free mci's memory in this case. Signed-off-by: Shaohui