Re: [PATCH] eeepc-laptop: remove disp attribute show function

2014-09-08 Thread Darren Hart
On Mon, Sep 08, 2014 at 02:57:23PM -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 08, 2014 at 11:44:38PM +0200, Frans Klaver wrote: > > On Mon, Sep 08, 2014 at 11:23:06PM +0200, Frans Klaver wrote: > > > On Mon, Sep 08, 2014 at 02:16:27PM -0700, Greg Kroah-Hartman wrote: > > > > On Mon, Sep 08, 201

Re: [PATCH] eeepc-laptop: remove disp attribute show function

2014-09-08 Thread Greg Kroah-Hartman
On Mon, Sep 08, 2014 at 11:44:38PM +0200, Frans Klaver wrote: > On Mon, Sep 08, 2014 at 11:23:06PM +0200, Frans Klaver wrote: > > On Mon, Sep 08, 2014 at 02:16:27PM -0700, Greg Kroah-Hartman wrote: > > > On Mon, Sep 08, 2014 at 11:12:42PM +0200, Frans Klaver wrote: > > > > > > > > EEEPC_CREATE_DEV

Re: [PATCH] eeepc-laptop: remove disp attribute show function

2014-09-08 Thread Greg Kroah-Hartman
On Mon, Sep 08, 2014 at 11:12:42PM +0200, Frans Klaver wrote: > The disp attribute is write-only. This is enforced by mimicking sysfs > behavior store_sys_acpi() and show_sys_acpi(), but this is not ideal. > Behaving like sysfs is better left to sysfs. > > Remove the show function from the disp at

[PATCH] eeepc-laptop: remove disp attribute show function

2014-09-08 Thread Frans Klaver
The disp attribute is write-only. This is enforced by mimicking sysfs behavior store_sys_acpi() and show_sys_acpi(), but this is not ideal. Behaving like sysfs is better left to sysfs. Remove the show function from the disp attribute. This ensures userspace can only write to disp at all times. Whi