Re: [PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-09-25 Thread Ard Biesheuvel
On Tue, 24 Sep 2019 at 01:17, Kees Cook wrote: > > On Fri, Sep 06, 2019 at 10:34:47AM -0700, Ard Biesheuvel wrote: > > On Fri, 6 Sep 2019 at 03:44, Will Deacon wrote: > > > > > > On Wed, Sep 04, 2019 at 01:38:04PM -0700, Kees Cook wrote: > > > > On Wed, Sep 04, 2019 at 11:38:03AM +0100, Will

Re: [PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-09-23 Thread Kees Cook
On Fri, Sep 06, 2019 at 10:34:47AM -0700, Ard Biesheuvel wrote: > On Fri, 6 Sep 2019 at 03:44, Will Deacon wrote: > > > > On Wed, Sep 04, 2019 at 01:38:04PM -0700, Kees Cook wrote: > > > On Wed, Sep 04, 2019 at 11:38:03AM +0100, Will Deacon wrote: > > > > On Wed, Aug 14, 2019 at 01:55:50PM -0700,

Re: [PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-09-06 Thread Ard Biesheuvel
On Fri, 6 Sep 2019 at 03:44, Will Deacon wrote: > > On Wed, Sep 04, 2019 at 01:38:04PM -0700, Kees Cook wrote: > > On Wed, Sep 04, 2019 at 11:38:03AM +0100, Will Deacon wrote: > > > On Wed, Aug 14, 2019 at 01:55:50PM -0700, Kees Cook wrote: > > > > diff --git

Re: [PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-09-06 Thread Will Deacon
On Wed, Sep 04, 2019 at 01:38:04PM -0700, Kees Cook wrote: > On Wed, Sep 04, 2019 at 11:38:03AM +0100, Will Deacon wrote: > > On Wed, Aug 14, 2019 at 01:55:50PM -0700, Kees Cook wrote: > > > diff --git a/drivers/firmware/efi/libstub/arm64-stub.c > > > b/drivers/firmware/efi/libstub/arm64-stub.c >

Re: [PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-09-04 Thread Kees Cook
On Wed, Sep 04, 2019 at 11:38:03AM +0100, Will Deacon wrote: > Hi Kees, > > On Wed, Aug 14, 2019 at 01:55:50PM -0700, Kees Cook wrote: > > When UEFI booting, if allocate_pages() fails (either via KASLR or > > regular boot), efi_low_alloc() is used for fall back. If it, too, fails, > > it reports

Re: [PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-09-04 Thread Will Deacon
Hi Kees, On Wed, Aug 14, 2019 at 01:55:50PM -0700, Kees Cook wrote: > When UEFI booting, if allocate_pages() fails (either via KASLR or > regular boot), efi_low_alloc() is used for fall back. If it, too, fails, > it reports "Failed to relocate kernel". Then handle_kernel_image() > reports the

[PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-08-14 Thread Kees Cook
When UEFI booting, if allocate_pages() fails (either via KASLR or regular boot), efi_low_alloc() is used for fall back. If it, too, fails, it reports "Failed to relocate kernel". Then handle_kernel_image() reports the failure to its caller, which unhelpfully reports exactly the same string again: