Re: [PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC

2015-11-03 Thread Saurabh Sengar
>It's slightly winding code, but if you look at the callers of >efivar_init() you'll see that none of them set both 'atomic' and >'duplicates', so dup_variable_bug() will never be called while holding >a spinlock. >Or am I missing something? I was assuming that there could be a possibility when b

[PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC

2015-10-27 Thread Saurabh Sengar
replace GFP_KERNEL with GFP_ATOMIC, as code while holding a spinlock should be atomic GFP_KERNEL may sleep and can cause deadlock, where as GFP_ATOMIC may fail but certainly avoids deadlock Signed-off-by: Saurabh Sengar --- drivers/firmware/efi/vars.c | 2 +- 1 file changed, 1 insertion(+), 1 de