RE: [PATCH] elevator: fix double release for elevator module

2015-04-23 Thread Chao Yu
Hi Jens and Jeff, Thanks for your review and help! :) Regards, > -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Friday, April 24, 2015 12:49 AM > To: Jeff Moyer; Chao Yu > Cc: linux-kernel@vger.kernel.org > Subject: Re: [PATCH] elevator: fix

Re: [PATCH] elevator: fix double release for elevator module

2015-04-23 Thread Jens Axboe
On 04/23/2015 08:59 AM, Jeff Moyer wrote: Chao Yu writes: Our issue is descripted in below call path: ->elevator_init ->elevator_init_fn ->{cfq,deadline,noop}_init_queue ->elevator_alloc ->kzalloc_node fail to call kzalloc_node and then put module in elevator_alloc; fail to c

Re: [PATCH] elevator: fix double release for elevator module

2015-04-23 Thread Jeff Moyer
Chao Yu writes: > Our issue is descripted in below call path: > ->elevator_init > ->elevator_init_fn > ->{cfq,deadline,noop}_init_queue >->elevator_alloc > ->kzalloc_node >fail to call kzalloc_node and then put module in elevator_alloc; > fail to call elevator_init_fn and then put

[PATCH] elevator: fix double release for elevator module

2015-04-23 Thread Chao Yu
Our issue is descripted in below call path: ->elevator_init ->elevator_init_fn ->{cfq,deadline,noop}_init_queue ->elevator_alloc ->kzalloc_node fail to call kzalloc_node and then put module in elevator_alloc; fail to call elevator_init_fn and then put module again in elevator_init. Re